Skip to content

[model-gateway][cleanup] Fix wrong comment in manager.rs#16601

Merged
slin1237 merged 1 commit intomainfrom
chang/fix-comment
Jan 7, 2026
Merged

[model-gateway][cleanup] Fix wrong comment in manager.rs#16601
slin1237 merged 1 commit intomainfrom
chang/fix-comment

Conversation

@CatherineSue
Copy link
Copy Markdown
Collaborator

@CatherineSue CatherineSue commented Jan 7, 2026

Motivation

// Extract URL from transport or use name is not true. The server_key only uses transport

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments (/tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci) or contact authorized users to do so.
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@CatherineSue CatherineSue changed the title Fix wrong comment in manager.rs [model-gateway][cleanup] Fix wrong comment in manager.rs Jan 7, 2026
@slin1237 slin1237 merged commit 4f443f4 into main Jan 7, 2026
62 of 64 checks passed
@slin1237 slin1237 deleted the chang/fix-comment branch January 7, 2026 00:32
michaelzhang-ai pushed a commit to michaelzhang-ai/sglang that referenced this pull request Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants