Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the testing coverage for the model gateway by introducing dedicated end-to-end tests for the embedding API. It ensures that embedding generation is functional, numerically correct, and consistently handled by the router across different backend configurations. The changes also include crucial updates to the test infrastructure to better manage model launching and provide clearer debugging information, ultimately enhancing the stability and maintainability of the embedding service. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive test suite for the embedding functionality, covering basic API usage, correctness against a reference implementation, and router behavior. The modifications to conftest.py to intelligently manage a default model for tests are a solid improvement. While the new tests are well-structured, I've identified a key area for improvement: several test helpers make individual API calls in a loop instead of sending a single batch request. This approach is inefficient and misses the opportunity to properly test the system's batching capabilities. My review includes suggestions to refactor these helpers to use batch API calls, which will make the tests more robust and efficient. Additionally, I've pointed out a few assertions that could be strengthened for better test accuracy. Overall, this is a valuable contribution that significantly enhances test coverage.
49e21ff to
91fc6d1
Compare
- Update conftest.py to properly detect e2e tests without explicit model markers and include DEFAULT_MODEL in pool requirements - Add embedding test suite (test_basic.py, test_correctness.py) - Add health check caching to avoid redundant worker health checks
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.