[1/N] Remove CacheConfig import in all model files#1658
Merged
zhyncs merged 4 commits intosgl-project:mainfrom Oct 14, 2024
Merged
[1/N] Remove CacheConfig import in all model files#1658zhyncs merged 4 commits intosgl-project:mainfrom
CacheConfig import in all model files#1658zhyncs merged 4 commits intosgl-project:mainfrom
Conversation
CacheConfig import in all model filesCacheConfig import in all model files
CacheConfig import in all model filesCacheConfig import in all model files
b5e30dc to
1328075
Compare
CacheConfig import in all model filesCacheConfig import in all model files
zhyncs
approved these changes
Oct 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This series of PRs attempt to decouple the model code from vLLM dependencies. There are mainly four components we use:
This PR removed the first one
CacheConfig. This is the easiest one because radix attention always set page size as 1 so we don't need to set cache config.Modifications
Remove
from vllm.config import CacheConfigin all modelsChecklist