[responses API] Add list_tools_for_servers and threading server_keys in routers#16540
Merged
[responses API] Add list_tools_for_servers and threading server_keys in routers#16540
Conversation
…penAI, thru ctx in gRPC
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
jamesjxliu
pushed a commit
to jamesjxliu/sglang
that referenced
this pull request
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes mcp tool leakage issue in grpc and openai routers.
When multiple requests use different MCP servers, there was a tool leakage issue:
Modifications
list_tools_for_serversinMcpManagerthat filters tools to static servers + specified dynamic serversis_static_server_by_keyto identify static servers (always visible)ensure_mcp_connectionto return server keys for a requestrequested_servers: Arc<StdRwLock<Vec<String>>>in gRPC contexts to store per-request server keysThreading Approaches
The commit uses two different approaches to pass server_keys:
Solution in Flow Chart
Accuracy Tests
The test sends two requests to the same grpc worker (regular). The first request contains a dynamic server A, the second request contains a dynamic server B. The two responses shows the mcp tools from their scope.
No static server is set up for this test.
Mcp: brave search server:
Response:
mcp_list_toolsshows tools from brave_web_searchClick to view the detailed response
Mcp: deepwiki
Response:
mcp_list_toolsshows onlydeepwikitoolsClick to view the detailed response
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci) or contact authorized users to do so.