Skip to content

[model-gateway] add model gateway multi-arch docker build, test and document docker image#15544

Merged
slin1237 merged 1 commit intomainfrom
smg-docker-opt
Dec 20, 2025
Merged

[model-gateway] add model gateway multi-arch docker build, test and document docker image#15544
slin1237 merged 1 commit intomainfrom
smg-docker-opt

Conversation

@slin1237
Copy link
Copy Markdown
Collaborator

@slin1237 slin1237 commented Dec 20, 2025

  • Set up QEMU for cross-platform emulation
  • Set up Docker Buildx for multi-arch builds
  • Build for linux/amd64 and linux/arm64 platforms
  • Update docker/login-action to v3

Checklist

@github-actions github-actions Bot added documentation Improvements or additions to documentation model-gateway labels Dec 20, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Dec 20, 2025

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the deployment flexibility of the sgl-model-gateway by introducing multi-architecture Docker images. This change allows users to easily deploy the gateway on both x86_64 and ARM64 systems, streamlining the installation process and broadening its compatibility. The accompanying documentation ensures users can quickly get started with the new Docker images.

Highlights

  • Multi-architecture Docker Images: The model gateway now supports multi-architecture Docker images, specifically for "linux/amd64" and "linux/arm64" platforms, making it deployable on a wider range of systems.
  • Docker Installation Documentation: The README.md has been updated to include clear instructions for pulling the pre-built multi-architecture Docker images from Docker Hub.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/pr-test-rust.yml
    • .github/workflows/release-docker-gateway.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the new multi-architecture Docker images for the SGLang Model Gateway. The change is clear and accurately reflects the new feature. I've suggested a small improvement to include a direct link to the Docker Hub repository for better user experience and consistency with other documentation. Please note that this review only covers the documentation change in sgl-model-gateway/README.md, as other changes related to the Docker build and test process were not included in the provided diff.

Comment thread sgl-model-gateway/README.md
@slin1237
[model-gateway] add model gateway multi-arch docker build, test and d…
268af39 
…ocument docker image

- Set up QEMU for cross-platform emulation
- Set up Docker Buildx for multi-arch builds
- Build for linux/amd64 and linux/arm64 platforms
- Update docker/login-action to v3
@slin1237 slin1237 merged commit 69412cc into main Dec 20, 2025
51 of 58 checks passed
@slin1237 slin1237 deleted the smg-docker-opt branch December 20, 2025 19:57
jiaming1130 pushed a commit to zhuyijie88/sglang that referenced this pull request Dec 25, 2025
@slin1237 @jiaming1130
[model-gateway] add model gateway multi-arch docker build, test and d…
e107fb7 
…ocument docker image (sgl-project#15544)
YChange01 pushed a commit to YChange01/sglang that referenced this pull request Jan 13, 2026
@slin1237 @YChange01
[model-gateway] add model gateway multi-arch docker build, test and d…
2a3bb83 
…ocument docker image (sgl-project#15544)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatherineSue CatherineSue Awaiting requested review from CatherineSue CatherineSue is a code owner

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Fridge003 Fridge003 Awaiting requested review from Fridge003 Fridge003 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@Kangyan-Zhou Kangyan-Zhou Awaiting requested review from Kangyan-Zhou Kangyan-Zhou is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation model-gateway run-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slin1237