Conversation
00cd46a to
2aebd9f
Compare
antinucleon
reviewed
Oct 6, 2024
5 tasks
3 tasks
merrymercy
reviewed
Oct 21, 2024
hcyz33
reviewed
Dec 4, 2024
| def set_kv_buffer( | ||
| self, | ||
| layer_id: int, | ||
| layer: RadixAttention, |
Contributor
There was a problem hiding this comment.
Why is it necessary to change the data type from int to RadixAttention here?
22 tasks
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Note that to support CUDA graph for encoder-decoder architecture like llama vision (mllama), we should make
encoder_lensthe part of the cuda graph, as thefull_text_row_masked_out_maskis decided byencoder_lensto skip the text-only req in a mixed batch.However, the current cuda graph backend (flashinfer) seems to have trouble handling the mixed batch. So we for now only accept the pure image decoding batch.
Todo in the following PRs:
sliding_window,single_attention,cross_attentionModifications
Checklist