Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
c563d81 to
0799de3
Compare
Collaborator
Author
|
/gemini review |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
- Add WorkerLoadGuard::attach_to_response() to tie guard lifetime to response body - Add attach_guards_to_response() for multiple guards (dual prefill/decode workers) - Implement GuardedBody and MultiGuardedBody wrappers using http_body::Body trait - Add LoadGuards::attach_to_response() convenience method in gRPC context - Refactor streaming processors to remove load_guards parameter - Update HTTP and gRPC routers to use attach pattern instead of manual drop - Add unit tests for RAII pattern verification This ensures load guards are properly dropped when: - Response body is fully consumed - Response body is dropped (client disconnect) - Multiple guards are attached (dual prefill/decode workers)
Contributor
|
Is there a release / docker image publish recently? I met some load unbalanced issue, if no release in these days I may need to build from source. |
Prozac614
pushed a commit
to Prozac614/sglang
that referenced
this pull request
Dec 23, 2025
jiaming1130
pushed a commit
to zhuyijie88/sglang
that referenced
this pull request
Dec 25, 2025
YChange01
pushed a commit
to YChange01/sglang
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures load guards are properly dropped when:
Checklist