Skip to content

[model-gateway] Improve logging across core modules#15497

Merged
slin1237 merged 1 commit intomainfrom
router-logs
Dec 19, 2025
Merged

[model-gateway] Improve logging across core modules#15497
slin1237 merged 1 commit intomainfrom
router-logs

Conversation

@slin1237
Copy link
Copy Markdown
Collaborator

@slin1237 slin1237 commented Dec 19, 2025

  • tool_parser: Change parsing failure warnings to debug (expected behavior)
  • grpc/harmony: Move verbose decoded text logs to trace level
  • grpc/regular: Move MCP tool loop internal messages to trace level
  • tokenizer: Move chat template discovery logs to debug level
  • tokenizer/cache: Remove redundant iterator scope comment
  • wasm: Move runtime initialization log to debug level
  • server: Move internal initialization details to debug level
  • app_context: Move TLS/mTLS config logs to debug level
  • middleware: Move queue processor startup log to debug level

Checklist

@slin1237
[model-gateway] Improve logging across core modules
baa4478 
- tool_parser: Change parsing failure warnings to debug (expected behavior)
- grpc/harmony: Move verbose decoded text logs to trace level
- grpc/regular: Move MCP tool loop internal messages to trace level
- tokenizer: Move chat template discovery logs to debug level
- tokenizer/cache: Remove redundant iterator scope comment
- wasm: Move runtime initialization log to debug level
- server: Move internal initialization details to debug level
- app_context: Move TLS/mTLS config logs to debug level
- middleware: Move queue processor startup log to debug level
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Dec 19, 2025

Summary of Changes

Hello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on refining the logging strategy across the model-gateway's core modules. By downgrading numerous info and warn level messages to debug or trace, the changes aim to reduce log verbosity for routine operations and expected behaviors. This improvement will result in cleaner, more focused logs, making it easier to identify critical issues and improving the overall observability experience.

Highlights

  • Logging Verbosity: Reduced the logging level for parsing failures in tool_parser from warn to debug, as these are often expected behaviors rather than critical issues.
  • GRPC Harmony Logging: Adjusted verbose decoded text logs in grpc/harmony to trace level, making them less intrusive during normal operation.
  • GRPC Regular Logging: Moved internal messages related to the MCP tool loop in grpc/regular to trace level for cleaner debug output.
  • Tokenizer Logging: Changed chat template discovery logs in the tokenizer module to debug level.
  • Tokenizer Cache: Removed a redundant comment regarding iterator scope in the tokenizer/cache module.
  • WASM Runtime Logging: Set WASM runtime initialization logs to debug level.
  • Server Initialization Logging: Reduced the logging level for various internal server initialization details to debug.
  • App Context Logging: Changed TLS/mTLS configuration and MCP manager initialization logs in app_context to debug level.
  • Middleware Logging: Moved queue processor startup logs in the middleware module to debug level.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors logging across various core modules to improve log clarity and reduce noise. The changes primarily involve downgrading log levels from info and warn to debug or trace for internal implementation details and expected error conditions, such as tool parsing failures. This is a valuable change for production environments. Additionally, there are minor cleanups like removing a redundant comment. The changes are consistent and well-implemented. I have no further suggestions.

@slin1237 slin1237 merged commit ba72e75 into main Dec 19, 2025
63 of 68 checks passed
@slin1237 slin1237 deleted the router-logs branch December 19, 2025 21:35
Prozac614 pushed a commit to Prozac614/sglang that referenced this pull request Dec 23, 2025
@slin1237 @Prozac614
[model-gateway] Improve logging across core modules (sgl-project#15497)
58557b6
jiaming1130 pushed a commit to zhuyijie88/sglang that referenced this pull request Dec 25, 2025
@slin1237 @jiaming1130
[model-gateway] Improve logging across core modules (sgl-project#15497)
8090220
YChange01 pushed a commit to YChange01/sglang that referenced this pull request Jan 13, 2026
@slin1237 @YChange01
[model-gateway] Improve logging across core modules (sgl-project#15497)
97c6d77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CatherineSue CatherineSue Awaiting requested review from CatherineSue CatherineSue is a code owner

@key4ng key4ng Awaiting requested review from key4ng key4ng is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deepseek model-gateway run-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@slin1237