[model-gateway] refactor: extract common graceful shutdown code before TLS branch#15494
[model-gateway] refactor: extract common graceful shutdown code before TLS branch#15494
Conversation
Move address parsing, handle creation, and graceful shutdown spawn logic before the if/else block to reduce code duplication between TLS and non-TLS paths.
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the server startup process by moving shared code for address parsing and graceful shutdown handling out of the conditional blocks for TLS and non-TLS configurations. This change significantly reduces code duplication, making the server initialization logic more concise and maintainable without altering its external behavior. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively refactors the server startup logic by extracting the common graceful shutdown code. Moving the address parsing, axum_server::Handle creation, and the shutdown signal handling logic out of the TLS and non-TLS branches significantly reduces code duplication and improves maintainability. The change is clean and achieves its goal. I have one minor suggestion to improve an error message to make it more informative for debugging.
Move address parsing, handle creation, and graceful shutdown spawn logic before the if/else block to reduce code duplication between TLS and non-TLS paths.
Checklist