[AMD] Fix and add accuracy-test-2-gpu-amd back#15415
Merged
HaiShaw merged 4 commits intosgl-project:mainfrom Dec 19, 2025
Merged
[AMD] Fix and add accuracy-test-2-gpu-amd back#15415HaiShaw merged 4 commits intosgl-project:mainfrom
HaiShaw merged 4 commits intosgl-project:mainfrom
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
HaiShaw
approved these changes
Dec 19, 2025
Prozac614
pushed a commit
to Prozac614/sglang
that referenced
this pull request
Dec 23, 2025
Co-authored-by: bingxche <Bingxu.Chen@amd.com>
jiaming1130
pushed a commit
to zhuyijie88/sglang
that referenced
this pull request
Dec 25, 2025
Co-authored-by: bingxche <Bingxu.Chen@amd.com>
YChange01
pushed a commit
to YChange01/sglang
that referenced
this pull request
Jan 13, 2026
Co-authored-by: bingxche <Bingxu.Chen@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-author : @bingxche
Motivation
To add accuracy-test-2-gpu-amd(test_moe_eval_accuracy_large.py) back, we add SGLANG_USE_AITER_AR=0 into the command, disabling the aiter custom_allreduce in this test.
Modifications
.github/workflows/pr-test-amd.yml
Accuracy Tests
Device - MI-325
Settings - SGLANG_USE_AITER_AR=0, num_threads=1024
Before - 0.268
After - 0.422
Ran 3 tests in 406.697s
Settings - SGLANG_USE_AITER_AR=1(default), num_threads=1
Before - 0.268
After - 0.421
Ran 3 tests in 1096.271s
Benchmarking and Profiling
Checklist