Skip to content

Add mooncake transfer_engine_bench into maunal test#14429

Merged
hnyls2002 merged 5 commits intomainfrom
lsyin/add-mooncake-transfer-ut
Dec 4, 2025
Merged

Add mooncake transfer_engine_bench into maunal test#14429
hnyls2002 merged 5 commits intomainfrom
lsyin/add-mooncake-transfer-ut

Conversation

@hnyls2002
Copy link
Copy Markdown
Collaborator

@hnyls2002 hnyls2002 commented Dec 4, 2025

target

./test_mooncake_transfer_engine.py --target

initiator

./test_mooncake_transfer_engine.py --initiator --mc-segment-id <target_server>:<port>
image

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Dec 4, 2025

Summary of Changes

Hello @hnyls2002, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new manual test script designed to streamline the process of benchmarking the Mooncake transfer engine. By providing a Python-based command-line interface, the script simplifies the execution of the underlying transfer_engine_bench tool, allowing developers to easily configure and run performance tests in either initiator or target roles, thereby improving the efficiency of performance validation for data transfer capabilities.

Highlights

  • New Manual Test Script: A new Python script, test_mooncake_transfer_engine.py, has been added to facilitate manual testing of the Mooncake transfer engine benchmark.
  • Benchmark Execution Wrapper: The script acts as a wrapper for the mooncake transfer_engine_bench tool, simplifying its execution with command-line arguments.
  • Initiator and Target Modes: It supports running the benchmark in both 'initiator' and 'target' modes, requiring a segment ID for the initiator.
  • Argument Parsing: The script parses arguments for metadata_server, mc_segment_id, bench_h2h (for host-to-host transfers), and device.
  • Mooncake Installation Check: It includes a check to ensure the mooncake library is installed, exiting gracefully if it's not found.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Dec 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new manual test script for benchmarking the Mooncake transfer engine. The script provides command-line arguments to configure the benchmark as an initiator or target. While the functionality is clear, there are critical security concerns regarding command execution and opportunities to improve argument validation for better user experience.

Comment thread test/manual/kv_transfer/test_mooncake_transfer_engine.py Outdated
Comment thread test/manual/kv_transfer/test_mooncake_transfer_engine.py Outdated
Comment thread test/manual/kv_transfer/test_mooncake_transfer_engine.py Outdated
Comment thread test/manual/kv_transfer/test_mooncake_transfer_engine.py Outdated
hnyls2002 and others added 4 commits December 4, 2025 22:28
@hnyls2002 @gemini-code-assist
Update test/manual/kv_transfer/test_mooncake_transfer_engine.py
871fcaf 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hnyls2002 @gemini-code-assist
Update test/manual/kv_transfer/test_mooncake_transfer_engine.py
80cec36 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hnyls2002 @gemini-code-assist
Update test/manual/kv_transfer/test_mooncake_transfer_engine.py
bfd5903 
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hnyls2002
udpate
f966e4f
@hnyls2002 hnyls2002 merged commit 441420e into main Dec 4, 2025
49 of 56 checks passed
@hnyls2002 hnyls2002 deleted the lsyin/add-mooncake-transfer-ut branch December 4, 2025 14:35
yingluosanqian pushed a commit to yingluosanqian/sglang that referenced this pull request Dec 4, 2025
@hnyls2002 @gemini-code-assist
Add mooncake transfer_engine_bench into maunal test (sgl-project#14429
bfce793 
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 5, 2025
@hnyls2002 @gemini-code-assist @tonyluj
Add mooncake transfer_engine_bench into maunal test (sgl-project#14429
3ffe8ff 
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
tonyluj pushed a commit to openanolis/sglang that referenced this pull request Dec 5, 2025
@hnyls2002 @gemini-code-assist @tonyluj
Add mooncake transfer_engine_bench into maunal test (sgl-project#14429
f22461b 
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
yuchengz816-bot pushed a commit to yuchengz816-bot/sglang that referenced this pull request Dec 8, 2025
@hnyls2002 @gemini-code-assist @yuchengz816-bot
Add mooncake transfer_engine_bench into maunal test (sgl-project#14429
f9b24e4 
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Kevin-XiongC pushed a commit to novitalabs/sglang that referenced this pull request Dec 9, 2025
@hnyls2002 @gemini-code-assist @Kevin-XiongC
Add mooncake transfer_engine_bench into maunal test (sgl-project#14429
b3ade8a 
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
YChange01 pushed a commit to YChange01/sglang that referenced this pull request Jan 13, 2026
@hnyls2002 @gemini-code-assist @YChange01
Add mooncake transfer_engine_bench into maunal test (sgl-project#14429
54ce598 
)

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hnyls2002