[AMD] fix the regression issue for DeepseekV3 on MI300#14383
Merged
HaiShaw merged 2 commits intosgl-project:mainfrom Dec 4, 2025
Merged
[AMD] fix the regression issue for DeepseekV3 on MI300#14383HaiShaw merged 2 commits intosgl-project:mainfrom
HaiShaw merged 2 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
HaiShaw
approved these changes
Dec 4, 2025
Collaborator
|
/tag-and-rerun-ci |
tom-jerr
pushed a commit
to tom-jerr/sglang
that referenced
this pull request
Dec 4, 2025
yingluosanqian
pushed a commit
to yingluosanqian/sglang
that referenced
this pull request
Dec 4, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
yuchengz816-bot
pushed a commit
to yuchengz816-bot/sglang
that referenced
this pull request
Dec 8, 2025
Kevin-XiongC
pushed a commit
to novitalabs/sglang
that referenced
this pull request
Dec 9, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
the root cause of the accuracy regression issue should be the commit from [PR-13960]
The critical code section should be here :
before [PR-13960] we hit both of these two if-condition if _is_fp8_fnuz and if _use_aiter on M300 :
, but with [PR-13960], the second if-condition if _use_aiter was changed to " elif _use_aiter " so that the code section under _use_aiter was skipped, causing the accuracy issue on MI300.
Modifications
python/sglang/srt/layers/quantization/fp8.py
Accuracy Tests
device: MI300
model:DeepSeek-V3-0324
test file: test_deepseek_v3_mtp.py
Accuracy: 0.950
Invalid: 0.000
Latency: 43.894 s
Output throughput: 460.814 token/s
metrics={'accuracy': 0.95, 'invalid': 0.0, 'latency': 43.894099209457636, 'output_throughput': 460.81364840132755}
avg_spec_accept_length=3.00316551100
devicce: MI355
model:DeepSeek-V3-0324
test file: test_deepseek_v3_mtp.py
Accuracy: 0.955
Invalid: 0.000
Latency: 16.481 s
Output throughput: 1204.678 token/s
metrics={'accuracy': 0.955, 'invalid': 0.0, 'latency': 16.48075593682006, 'output_throughput': 1204.6777511973037}
avg_spec_accept_length=2.9998464137613268
device: MI300
model:DeepSeek-R1-0528
server script:
Benchmarking and Profiling
Checklist