Add constrained_json_whitespace_pattern to ServerArgs#1438
Merged
merrymercy merged 2 commits intosgl-project:mainfrom Sep 16, 2024
Merged
Add constrained_json_whitespace_pattern to ServerArgs#1438merrymercy merged 2 commits intosgl-project:mainfrom
merrymercy merged 2 commits intosgl-project:mainfrom
Conversation
merrymercy
reviewed
Sep 16, 2024
merrymercy
approved these changes
Sep 16, 2024
5 tasks
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CC @qeternity @max99x
Motivation
It's hard to find a single whitespace pattern that works for all models(see dottxt-ai/outlines#691). I think it's better to leave the choice to the users.
Related PR: #1277
Modifications
constrained_json_whitespace_patternis added toServerArgswith the default value set toNone(usesoutlinesdefault value).Checklist