[CI] update estimated elapsed time of some unittests#14347
Conversation
Summary of ChangesHello @ch-wan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the continuous integration process by adjusting the estimated execution times for a significant number of unit tests. The updates are based on recent performance data collected from scheduled PR tests on the main branch, ensuring that the CI system's time allocations for these tests are more precise and up-to-date. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the estimated elapsed times for several unit tests in the CI configuration. The changes are based on recent test runs, which is a good practice for maintaining efficient CI scheduling. I've found one issue: a duplicated test entry in the per-commit-1-gpu suite, which would cause a test to run twice. I've suggested its removal. Otherwise, the changes look good.
| TestFile("test_vision_chunked_prefill.py", 117), | ||
| TestFile("test_vision_openai_server_a.py", 778), | ||
| TestFile("test_vlm_input_format.py", 166), | ||
| TestFile("test_modelopt_loader.py", 30), |
There was a problem hiding this comment.
The test file test_modelopt_loader.py is duplicated in this suite. It is already defined on line 92 with an updated time of 11s. This second entry on line 133 has an old value of 30s and is also misplaced alphabetically. This will cause the test to run twice and use an incorrect time for partitioning, which is inefficient. Please remove this duplicate entry.
9c8af94 to
503700c
Compare
Motivation
Collected and updated estimated elapsed time of some unittests based on the median values of three latest scheduled PR tests for the main branch.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist