[model-gateway] use worker crate in openai router#14330
Conversation
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the OpenAI router by integrating it with the new worker management system. The primary goal is to centralize the discovery, health checking, and selection of OpenAI-compatible API endpoints through a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a significant and well-executed refactoring of the OpenAI router to use the worker crate abstractions. The changes simplify the router's logic by delegating worker management, health checks, and model discovery to the WorkerRegistry. This makes the OpenAIRouter much cleaner and more maintainable. The test suite has also been updated thoroughly to reflect these changes.
I've identified a couple of critical issues related to potential panics when handling API keys, which could crash the service. I've also included some medium-severity suggestions to improve the robustness of the model information retrieval. Overall, this is a great improvement to the codebase.
2c006c2 to
bdf9839
Compare
cb1f364 to
11c9829
Compare
e535f2e to
d494686
Compare
Checklist