[model-gateway] Migrate Worker trait to model-aware methods#14250
Merged
[model-gateway] Migrate Worker trait to model-aware methods#14250
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
harvenstar
pushed a commit
to harvenstar/sglang
that referenced
this pull request
Dec 4, 2025
tonyluj
pushed a commit
to openanolis/sglang
that referenced
this pull request
Dec 5, 2025
yuchengz816-bot
pushed a commit
to yuchengz816-bot/sglang
that referenced
this pull request
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the Worker trait migration to model-aware methods, building on the ModelCard/ModelType foundation.
Key changes:
model_idparameter for model-specific config lookupModelCardobjects instead of thelabelsHashMapModelCardobjects from configMotivation
Previously, model-related configuration was scattered in the
labelsHashMap as untyped strings. This made it:Now model config is properly typed in
ModelCardwith IDE autocomplete and compile-time checking.Changes
Worker trait methods - Changed signature from
fn tokenizer_path(&self)tofn tokenizer_path(&self, model_id: &str)(same for reasoning_parser, tool_parser, chat_template)WorkerBuilder - Added
models(Vec<ModelCard>)andmodel(ModelCard)builder methodsCreateWorkerStep - Creates
ModelCardfromWorkerConfigRequestinstead of storing in labelsTest plan
worker_to_info()returns correct model config