Skip to content

[AMD] Add more tests to AMD CI and add diffusion dependencies#13743

Closed
hubertlu-tw wants to merge 7 commits intosgl-project:mainfrom
hubertlu-tw:ci_update_1121_diffusion
Closed

[AMD] Add more tests to AMD CI and add diffusion dependencies#13743
hubertlu-tw wants to merge 7 commits intosgl-project:mainfrom
hubertlu-tw:ci_update_1121_diffusion

Conversation

@hubertlu-tw
Copy link
Copy Markdown
Collaborator

@hubertlu-tw hubertlu-tw commented Nov 21, 2025

Motivation

Added more tests to AMD CI and diffusion dependencies along with a placeholder for diffusion-related test in AMD CI

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Nov 21, 2025
@hubertlu-tw hubertlu-tw changed the title [AMD] Added more tests to AMD CI and added diffusion dependencies [AMD] Add more tests to AMD CI and add diffusion dependencies Nov 21, 2025
@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented Nov 21, 2025

Summary of Changes

Hello @hubertlu-tw, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the AMD Continuous Integration (CI) environment by integrating necessary dependencies for diffusion models and substantially expanding the test coverage. It introduces a more flexible dependency management system for CI scripts and ensures test compatibility by conditionally skipping Flashinfer-related tests on AMD hardware where it's not supported.

Highlights

  • Diffusion Dependencies: Added diffusion as an optional dependency group in python/pyproject_other.toml and included it in the pip install commands within the docker/rocm.Dockerfile for AMD builds.
  • Expanded AMD CI Tests: Significantly increased the number of test cases run in the AMD CI suite by adding numerous new test files across various components like quantization, LoRA, and model layers.
  • Dynamic Dependency Installation: Modified the AMD CI dependency installation script to support dynamic inclusion of optional Python extras, making the CI setup more flexible.
  • Flashinfer Compatibility: Added skip conditions for Flashinfer-based deterministic tests on HIP (AMD) platforms, acknowledging its current lack of support.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/pr-test-amd.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Nov 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds diffusion dependencies and expands the AMD CI test suite. The changes are logical and well-implemented. I have one suggestion regarding dependency pinning to improve reproducibility.

Comment thread python/pyproject_other.toml
Comment on lines +112 to +113
"cloudpickle",
"remote-pdb",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better reproducibility, it's a good practice to pin all dependencies within an optional dependency group. I notice that cloudpickle and remote-pdb are not pinned, while most other packages in the diffusion group have specific versions. Pinning these versions will help ensure a consistent environment and prevent unexpected breakages from upstream dependency updates.

@hubertlu-tw
Copy link
Copy Markdown
Collaborator Author

hubertlu-tw commented Nov 21, 2025

/tag-and-rerun-ci

@zyzshishui zyzshishui mentioned this pull request Nov 22, 2025
Merged
6 tasks
zyzshishui added a commit to zyzshishui/sglang that referenced this pull request Nov 27, 2025
@zyzshishui @hubertlu-tw
Manually merge sgl-project#13743
437dfb0 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
@sabreshao sabreshao mentioned this pull request Dec 2, 2025
Closed
5 tasks
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 10, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
bd0780d 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 10, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
35a93ff 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit that referenced this pull request Dec 12, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge #13743
3d250f2 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit that referenced this pull request Dec 15, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge #13743
91f4235 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 15, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
00998f0 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 16, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
694efd4 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 17, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
9fd27f3 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 18, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
c412271 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
sunxxuns pushed a commit to zyzshishui/sglang that referenced this pull request Dec 19, 2025
@zyzshishui @hubertlu-tw @sunxxuns
Manually merge sgl-project#13743
9ac1c7b 
Co-authored-by: Hubert Lu <Hubert.Lu@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HaiShaw HaiShaw Awaiting requested review from HaiShaw HaiShaw is a code owner

@saienduri saienduri Awaiting requested review from saienduri

@Fridge003 Fridge003 Awaiting requested review from Fridge003 Fridge003 is a code owner

@ispobock ispobock Awaiting requested review from ispobock ispobock is a code owner

@ishandhanani ishandhanani Awaiting requested review from ishandhanani ishandhanani is a code owner

@merrymercy merrymercy Awaiting requested review from merrymercy merrymercy is a code owner

@Kangyan-Zhou Kangyan-Zhou Awaiting requested review from Kangyan-Zhou Kangyan-Zhou is a code owner

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

amd dependencies Pull requests that update a dependency file run-ci

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hubertlu-tw