[triton] Remove the zero initialization of qk_acc by directly writing the result#1288
Merged
merrymercy merged 3 commits intosgl-project:mainfrom Sep 1, 2024
Merged
Conversation
Collaborator
|
A series of nice work! Would you like to join our Slack channel https://sgl-fru7574.slack.com/ssb/redirect? Thanks! |
Collaborator
Author
|
hmm the link doesn't work. can you invite me at byronhsu1230@gmail.com? |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, we do tl.zeros + tl.dot just to write qk to acc, but this can be simplified thanks to https://triton-lang.org/main/python-api/generated/triton.language.dot.html#triton.language.dot. Maybe triton compiler already does the optimization, but it is good to keep the code simple.
Modifications
Original:
New
Checklist