[Chore] Rename model_overide_args to model_override_args#1284
Merged
merrymercy merged 2 commits intosgl-project:mainfrom Sep 1, 2024
Merged
[Chore] Rename model_overide_args to model_override_args#1284merrymercy merged 2 commits intosgl-project:mainfrom
merrymercy merged 2 commits intosgl-project:mainfrom
Conversation
zhyncs
approved these changes
Sep 1, 2024
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
…#1284) Signed-off-by: Kai-Hsun Chen <kaihsun@anyscale.com> Co-authored-by: Yineng Zhang <me@zhyncs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rename
model_overide_argstomodel_override_args. However,model_overide_argsseems to be a user-facing API that is used bysrt_example_llava_v.py. Therefore, this PR introduces a breaking change.Modifications
Checklist