Skip to content

test: relax VLM input format assertions for image understanding#12755

Merged
zhaochenyang20 merged 1 commit intosgl-project:refactor-engine-vlm-paramsfrom
minleminzui:refactor-engine-vlm-params
Nov 6, 2025
Merged

test: relax VLM input format assertions for image understanding#12755
zhaochenyang20 merged 1 commit intosgl-project:refactor-engine-vlm-paramsfrom
minleminzui:refactor-engine-vlm-params

Conversation

@minleminzui
Copy link
Copy Markdown
Collaborator

Motivation

Make VLMInputTestBase.verify_response less brittle by checking for
keywords (taxi/car + SG/SGL/logo/company) instead of enforcing exact
phrasing like "sg" and "text". This keeps the test focused on whether
the model understands the two images while avoiding overfitting to a
specific generation style across Qwen and Gemma.

#10532

Modifications

Accuracy Tests

Benchmarking and Profiling

Checklist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

Copy link
Copy Markdown
Collaborator

@zhaochenyang20 zhaochenyang20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice done

@zhaochenyang20 zhaochenyang20 merged commit 23ed885 into sgl-project:refactor-engine-vlm-params Nov 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants