misc: rm unused model_loader#1110
Merged
merrymercy merged 1 commit intosgl-project:mainfrom Aug 15, 2024
zhyncs:misc
Merged
Conversation
hnyls2002
pushed a commit
to yichuan-w/sglang
that referenced
this pull request
Aug 16, 2024
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
While reviewing the code, it was discovered that this section of code is not being used and seems to have been broken up. For example, in
python/sglang/srt/model_loader/utils.py,from sglang.srt.layers.quantization import get_quantization_config, but actually there is no quantization file under thelayersdirectory anymore. This should be due to incomplete deletion previously.Modification
Checklist
pre-commit run --all-filesor other linting tools are used to fix potential lint issues.