Skip to content

[Feature] modify Runtime to support skip_tokenizer_init#1088

Merged
merrymercy merged 5 commits intosgl-project:mainfrom
gryffindor-rr:main
Aug 14, 2024
Merged

[Feature] modify Runtime to support skip_tokenizer_init#1088
merrymercy merged 5 commits intosgl-project:mainfrom
gryffindor-rr:main

Conversation

@gryffindor-rr
Copy link
Copy Markdown
Contributor

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

#924

Modification

modify Runtime (i.e. async generate_request) to handle ids when skip_tokenizer_init is set.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@zhyncs
Copy link
Copy Markdown
Collaborator

zhyncs commented Aug 14, 2024

Is this a follow-up to #959?

@gryffindor-rr
Copy link
Copy Markdown
Contributor Author

Is this a follow-up to #959?

yes.

@merrymercy merrymercy enabled auto-merge (squash) August 14, 2024 07:27
@merrymercy merrymercy disabled auto-merge August 14, 2024 07:28
@merrymercy merrymercy merged commit 616b59f into sgl-project:main Aug 14, 2024
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants