Skip to content

Fix create_abort_task, GenerateReqInput does not have rids.#1079

Merged
merrymercy merged 1 commit intosgl-project:mainfrom
gryffindor-rr:main
Aug 13, 2024
Merged

Fix create_abort_task, GenerateReqInput does not have rids.#1079
merrymercy merged 1 commit intosgl-project:mainfrom
gryffindor-rr:main

Conversation

@gryffindor-rr
Copy link
Copy Markdown
Contributor

Thank you for your contribution, we really appreciate it. The following instructions will help improve your pull request and make it easier to receive feedback. If there are any items you don't understand, don't worry. Just submit the pull request and ask the maintainers for help.

Motivation

File "/usr/local/python/lib/python3.10/site-packages/starlette/_exception_handler.py", line 53, in wrapped_app
await app(scope, receive, sender)
File "/usr/local/python/lib/python3.10/site-packages/starlette/routing.py", line 75, in app
await response(scope, receive, send)
File "/usr/local/python/lib/python3.10/site-packages/starlette/responses.py", line 268, in call
await self.background()
File "/usr/local/python/lib/python3.10/site-packages/starlette/background.py", line 45, in call
await task()
File "/usr/local/python/lib/python3.10/site-packages/starlette/background.py", line 28, in call
await self.func(*self.args, **self.kwargs)
File "/workspace/opensource/sglang/python/sglang/srt/managers/tokenizer_manager.py", line 511, in abort_request
for rid in obj.rids:
AttributeError: 'GenerateReqInput' object has no attribute 'rids'. Did you mean: 'rid'

Modification

fix typo.

Checklist

  1. Ensure pre-commit pre-commit run --all-files or other linting tools are used to fix potential lint issues.
  2. Confirm that modifications are covered by complete unit tests. If not, please add more unit tests for correctness.
  3. Modify documentation as needed, such as docstrings or example tutorials.

@merrymercy merrymercy enabled auto-merge (squash) August 13, 2024 12:35
@merrymercy merrymercy merged commit 95f5fbf into sgl-project:main Aug 13, 2024
timethink pushed a commit to timethink/sglang that referenced this pull request Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants