Conversation
zhyncs
reviewed
Aug 12, 2024
zhyncs
reviewed
Aug 12, 2024
Collaborator
|
@Ying1123 We can temporarily change |
7ac08ad to
0ad6781
Compare
NihalPotdar
reviewed
Aug 13, 2024
NihalPotdar
left a comment
There was a problem hiding this comment.
I tried out the engine with the gemma-2-2b, 9b, and 27b models, and looks good. Left some quick comments. Overall lgtm!
06d3450 to
f0f9941
Compare
224b293 to
749a8ff
Compare
merrymercy
approved these changes
Aug 13, 2024
merrymercy
reviewed
Aug 13, 2024
merrymercy
reviewed
Aug 14, 2024
merrymercy
reviewed
Aug 14, 2024
| self.disable_radix_cache = True | ||
| self.disable_regex_jump_forward = True | ||
| self.disable_flashinfer = False | ||
| self.disable_cuda_graph = True |
Contributor
There was a problem hiding this comment.
cuda graph should be turned on
merrymercy
reviewed
Aug 14, 2024
merrymercy
reviewed
Aug 14, 2024
29 tasks
Contributor
Author
|
Additional comments addressed in #1090 |
timethink
pushed a commit
to timethink/sglang
that referenced
this pull request
Mar 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT turn on auto-merge.
I'll merge it manually.