Example file for docker compose and k8s#1006
Conversation
|
Could you revert your changes to the entry points? |
|
@LucienShui May you rebase the latest main branch? Thanks. ref #1033 |
|
cc @LucienShui ref cmd # first sync fork's main
# next
git checkout main
git pull
git checkout chore/docker_entrypoint
git rebase main
git push -f |
f7ec3d1 to
bd4b7ec
Compare
|
Hi @LucienShui I noticed that you updated your PR. Have the compose and k8s conf been locally verified? |
Yes, both compose and k8s have been verified locally, but I want to simplify these files as much as possible to make them more beginner-friendly so I added Feel free to merge it now but it would be better after I make more changes. BTW, I need to work during the day so I only have time in the evening, my timezone is UTC+8. |
|
Got it. Thanks! |
8c0e903 to
652f2a0
Compare
|
This PR is ready to merge, thanks for your time and patience! |
| @@ -0,0 +1,66 @@ | |||
| apiVersion: node.k8s.io/v1 | |||
There was a problem hiding this comment.
May we add health check, image pull policy and network policy?
There was a problem hiding this comment.
Sorry, I've just started learning k8s for 4 days, after searching, I still have no idea about what the network policy should do here.
Health check and pull policy was added.
There was a problem hiding this comment.
It's basically done, and I currently don't have the appropriate environment. It might need to wait for another reviewer to do a simple local verification. Thank you for your contribution!
b71fbdf to
0b082f5
Compare
|
@LucienShui Thanks for the contribution! |
Motivation
More convenience to start with docker.
Modification
compose.ymlfor serving as service.README.mdfor corresponding changes.