fix: typo in `gu` post-install actions by mantasindrasius · Pull Request #99 · sgammon/rules_graalvm

mantasindrasius · 2023-09-03T16:29:31Z

I couldn't find a proper example as well as I didn't manage to make the graalvm working due to following issues:L

There seems to be a typo bug in graalvm_bindist.bzl.
After fixing the bug and installing js, I'm still getting the error below, so I'd like @sgammon 's help to make a working example:

Exception in thread "main" java.lang.IllegalArgumentException: A language with id 'js' is not installed. Installed languages are: [].
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotEngineException.illegalArgument(PolyglotEngineException.java:131)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotEngineImpl.throwNotInstalled(PolyglotEngineImpl.java:1109)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotEngineImpl.requirePublicLanguage(PolyglotEngineImpl.java:1116)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotContextImpl.requirePublicLanguage(PolyglotContextImpl.java:1491)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotContextImpl.lookupLanguageContext(PolyglotContextImpl.java:1453)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotContextImpl.eval(PolyglotContextImpl.java:1462)
	at org.graalvm.truffle/com.oracle.truffle.polyglot.PolyglotContextDispatch.eval(PolyglotContextDispatch.java:63)
	at org.graalvm.sdk/org.graalvm.polyglot.Context.eval(Context.java:399)
	at org.graalvm.sdk/org.graalvm.polyglot.Context.eval(Context.java:425)
	at Main.main(Main.java:14)

example/integration_tests/bazel6-components/sample/Main.java

sgammon · 2023-09-03T22:50:46Z

@mantasindrasius I've discovered the bug, which I filed as #100. I'm pushing a fix and then I will return to this PR to amend the test. Thanks again or reporting. It looks like transitive component dependencies were installed, but not the actual direct dependencies requested by the user (oops).

@mantasindrasius

- fix: add requested component to list of effective components installed via bindist Fixes and closes #100. Thanks to @mantasindrasius for reporting! Relates-To: #100 Relates-To: #99 Signed-off-by: Sam Gammon <sam@elide.ventures>

@mantasindrasius

- fix: add requested component to list of effective components installed via bindist Fixes and closes #100. Thanks to @mantasindrasius for reporting! Relates-To: #100 Relates-To: #99 Signed-off-by: Sam Gammon <sam@elide.ventures>

sgammon · 2023-09-03T23:11:24Z

example/integration_tests/components-ce/.bazelrc

@@ -1 +1,3 @@
 build --enable_bzlmod
+build --java_runtime_version=graalvm_20
+build --tool_java_runtime_version=graalvm_20


this is how you use the GraalVM JVM as your Java Toolchain in Bazel, which you must do so that it can find the GraalVM org.graalvm.polyglot.Context type.

the other way to do this is to install and build against org.graalvm.sdk:graal-sdk from Maven, which provides these symbols on non-GraalVM runtimes.

sgammon · 2023-09-03T23:11:34Z

example/integration_tests/components-ce/MODULE.bazel

 bazel_dep(
    name = "rules_java",
-    version = "6.5.0",
+    version = "6.4.0",


bazel 6 needs rules_java 6.4.0 or previous

sgammon · 2023-09-03T23:12:00Z

example/integration_tests/components-ce/sample/BUILD.bazel

+    extra_args = [
+        "--language:js",
+    ],


enabling the component in the native_image: the components-ce sample, which was on the release/0.10.x branch, has taken on this test.

sgammon · 2023-09-03T23:12:14Z

example/integration_tests/components-ce/sample/Main.java

+        OutputStream myOut = new BufferedOutputStream(System.out);
+        Context context = Context.newBuilder("js")
+                .out(myOut)
+                .allowAllAccess(true)
+                .build();
+        context.eval("js", "42");
+        context.close();


i've kept your test code, but moved it to components-ce, where we are already testing components.

@mantasindrasius

- fix: add requested component to list of effective components installed via bindist Fixes and closes #100. Thanks to @mantasindrasius for reporting! Relates-To: #100 Relates-To: #99 Signed-off-by: Sam Gammon <sam@elide.ventures>

sgammon · 2023-09-03T23:15:36Z

this will ship with #80 instead of being merged directly into main, because it now depends on the 0.10.x (the components-ce test is included in that branch).

update: actually, i can split the test and fix commits so i can cherry-pick the fix on to main safely, which is what I will do.

@mantasindrasius

- fix: `startsWith` should be `startswith` - test: update `components-ce` test to include component usage Thank you to @mantasindrasius! Co-authored-by: Mantas Indrašius <mantasi@wix.com> Signed-off-by: Sam Gammon <sam@elide.ventures>

- test: add code to `components-ce` test to ensure `js` component is installed and usable Co-authored-by: Mantas Indrašius <mantasi@wix.com> Signed-off-by: Sam Gammon <sam@elide.ventures>

sonarqubecloud · 2023-09-03T23:23:33Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

sgammon · 2023-09-03T23:28:36Z

@mantasindrasius We're good to go here.

Here's what you should do:

graalvm_repository(
    name = "graalvm",
    components = [
        "js",  # you only need this, not the `setup_action`
    ],
    distribution = "oracle",
    java_version = "20",
    version = "20.0.2",
)

# ...

register_toolchains("@graalvm//:jvm")  # registers the Java Toolchain
register_toolchains("@graalvm//:sdk")  # registers the native-image toolchain

In your .bazelrc:

build --java_runtime_version=graalvm_20
build --tool_java_runtime_version=graalvm_20

Then, in your BUILD.bazel file:

native_image(
    name = "main-native",
    main_class = "Main",
    deps = [":java"],
    extra_args = [
        "--language:js",  # add this to build `js` into your `native-image`
    ],
)

Note that there is no need to provide the native_image_tool attribute, since in this case it is using Toolchains to resolve native-image.

This will build JS into your native image target; it also sets up your Java toolchains so you can build against the GraalVM SDK types. Once this PR is merged, you will want to use the release/0.10.x branch, which has the latest fixes and toolchain support. You can consult the components-ce sample if you want to see how it works. I've manually tested that sample against Bazel 6.3.2.

mantasindrasius · 2023-09-04T08:15:41Z

Amazing. Thanks for responsiveness!

This comment was marked as outdated.

Sign in to view

sgammon reviewed Sep 3, 2023

View reviewed changes

example/integration_tests/bazel6-components/sample/Main.java Show resolved Hide resolved

sgammon mentioned this pull request Sep 3, 2023

Component direct dependencies not installed #100

Closed

sgammon mentioned this pull request Sep 3, 2023

fix: install requested components plus deps #101

Merged

sgammon changed the title ~~Example with components usage and a startswith method typo fix~~ fix: typo in gu post-install actions Sep 3, 2023

sgammon mentioned this pull request Sep 3, 2023

Release: 0.10.x #80

Merged

sgammon force-pushed the install-typo-fix branch from 37a2902 to a571524 Compare September 3, 2023 23:09

sgammon changed the base branch from main to release/0.10.x September 3, 2023 23:09

sgammon force-pushed the install-typo-fix branch from a571524 to 65d9ebe Compare September 3, 2023 23:10

sgammon approved these changes Sep 3, 2023

View reviewed changes

sgammon marked this pull request as ready for review September 3, 2023 23:12

sgammon self-assigned this Sep 3, 2023

sgammon added bug Something isn't working components Issues relating to GraalVM components labels Sep 3, 2023

sgammon added this to the 1.0.0 milestone Sep 3, 2023

sgammon linked an issue Sep 3, 2023 that may be closed by this pull request

Typo in the gu post-install actions #102

Closed

sgammon force-pushed the install-typo-fix branch 2 times, most recently from 5c9350a to 035b51b Compare September 3, 2023 23:21

sgammon and others added 2 commits September 3, 2023 16:22

fix: typo in gu post-install actions

710a1ba

- fix: `startsWith` should be `startswith` - test: update `components-ce` test to include component usage Thank you to @mantasindrasius! Co-authored-by: Mantas Indrašius <mantasi@wix.com> Signed-off-by: Sam Gammon <sam@elide.ventures>

test: extend components-ce to test js use

2104679

- test: add code to `components-ce` test to ensure `js` component is installed and usable Co-authored-by: Mantas Indrašius <mantasi@wix.com> Signed-off-by: Sam Gammon <sam@elide.ventures>

sgammon force-pushed the install-typo-fix branch from 035b51b to 2104679 Compare September 3, 2023 23:23

sgammon merged commit 9fd60a7 into sgammon:release/0.10.x Sep 4, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: typo in `gu` post-install actions#99

fix: typo in `gu` post-install actions#99
sgammon merged 2 commits intosgammon:release/0.10.xfrom
mantasindrasius:install-typo-fix

mantasindrasius commented Sep 3, 2023 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

sgammon commented Sep 3, 2023 •

edited

Loading

Uh oh!

sgammon Sep 3, 2023

Uh oh!

sgammon Sep 3, 2023

Uh oh!

sgammon Sep 3, 2023

Uh oh!

sgammon Sep 3, 2023

Uh oh!

sgammon commented Sep 3, 2023 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Sep 3, 2023

Uh oh!

sgammon commented Sep 3, 2023 •

edited

Loading

Uh oh!

mantasindrasius commented Sep 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mantasindrasius commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

sgammon commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sgammon Sep 3, 2023

Choose a reason for hiding this comment

Uh oh!

sgammon Sep 3, 2023

Choose a reason for hiding this comment

Uh oh!

sgammon Sep 3, 2023

Choose a reason for hiding this comment

Uh oh!

sgammon Sep 3, 2023

Choose a reason for hiding this comment

Uh oh!

sgammon commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Sep 3, 2023

Uh oh!

sgammon commented Sep 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mantasindrasius commented Sep 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mantasindrasius commented Sep 3, 2023 •

edited

Loading

sgammon commented Sep 3, 2023 •

edited

Loading

sgammon commented Sep 3, 2023 •

edited

Loading

sgammon commented Sep 3, 2023 •

edited

Loading