fix(native_image): fix C++ toolchain env setup#72
Closed
fmeum wants to merge 3 commits intosgammon:mainfrom
Closed
fix(native_image): fix C++ toolchain env setup#72fmeum wants to merge 3 commits intosgammon:mainfrom
fmeum wants to merge 3 commits intosgammon:mainfrom
Conversation
Make use of `Args` lazy string formatting to save memory. Also pass in compiler options as repeated flags, not joined on spaces, to prevent issues when compiler options contain spaces.
`depset` structures should be kept as flat as possible. C++ toolchain files are also already `depset`s and thus shouldn't be passed into `tools`.
Instead of relying on the default shell env, get the environment variables declared by the C++ toolchain. On macOS, additionally use `apple_support` to pass in `DEVELOPER_DIR`. Since GraalVM sanitizes the environment, all variables are translated into `-E` flags.
Collaborator
Author
|
Kudos, SonarCloud Quality Gate passed!
|
This was referenced Aug 31, 2023
Collaborator
Author
|
@keith This is what I came up with based on your diff. It works in Bazel CI :-) |
sgammon
added a commit
that referenced
this pull request
Sep 1, 2023
- fix: use legacy rules from legacy gvm - chore: drop `MODULE-resolved.bzl` - chore: update bzlmod lock - chore: update lib/docs deps and rebuild docs - chore: remove redundant calls in sample projects Applied on top of #72 Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added a commit
that referenced
this pull request
Sep 1, 2023
- fix: use legacy rules from legacy gvm - chore: drop `MODULE-resolved.bzl` - chore: update bzlmod lock - chore: update lib/docs deps and rebuild docs - chore: remove redundant calls in sample projects Applied on top of #72 Signed-off-by: Sam Gammon <sam@elide.ventures>
Merged
Collaborator
Author
|
I can see how We could also mimic what |
Owner
|
@fmeum see #80, i've performed the rule split and refactor in anticipation of that same problem. bazel4 is fixed, mac tests are working, and that PR now includes this one as well as #73 i hope we can move discussion to #80 where we can prep a release at as such closing this (but only as long as that PR works for your needs @fmeum -- if you hit issues we can always reopen this one.) |
sgammon
added a commit
that referenced
this pull request
Sep 2, 2023
- fix: use legacy rules from legacy gvm - chore: drop `MODULE-resolved.bzl` - chore: update bzlmod lock - chore: update lib/docs deps and rebuild docs - chore: remove redundant calls in sample projects Applied on top of #72 Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added a commit
that referenced
this pull request
Sep 4, 2023
- fix: use legacy rules from legacy gvm - chore: drop `MODULE-resolved.bzl` - chore: update bzlmod lock - chore: update lib/docs deps and rebuild docs - chore: remove redundant calls in sample projects Applied on top of #72 Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added a commit
that referenced
this pull request
Sep 8, 2023
- fix: use legacy rules from legacy gvm - chore: drop `MODULE-resolved.bzl` - chore: update bzlmod lock - chore: update lib/docs deps and rebuild docs - chore: remove redundant calls in sample projects Applied on top of #72 Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added a commit
that referenced
this pull request
Sep 8, 2023
- fix: use legacy rules from legacy gvm - chore: drop `MODULE-resolved.bzl` - chore: update bzlmod lock - chore: update lib/docs deps and rebuild docs - chore: remove redundant calls in sample projects Applied on top of #72 Signed-off-by: Sam Gammon <sam@elide.ventures>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of relying on the default shell env, get the environment
variables declared by the C++ toolchain. On macOS, additionally use
apple_supportto pass inDEVELOPER_DIR.Since GraalVM sanitizes the environment, all variables are translated
into
-Eflags.Fixes #67