Raise an error if peer certificate chain APIs aren't available#149
Merged
Conversation
davisagli
approved these changes
Aug 14, 2024
davisagli
requested changes
Aug 14, 2024
davisagli
left a comment
Collaborator
There was a problem hiding this comment.
Well, I shouldn't have approved it, because it's breaking tests.
Owner
Author
|
@davisagli Yeah the way I'm checking for existence of that method needs some work, figuring out an alternative that works across versions. Appreciate the quick review! :) |
Owner
Author
|
I wasn't able to quickly get GraalPy to work with |
Owner
Author
|
The failure on Windows has been around for a long time, we should dig into that one but this PR can move forward without it. |
davisagli
reviewed
Aug 15, 2024
davisagli
approved these changes
Aug 21, 2024
Owner
Author
|
Thanks for the review @davisagli! |
SaschaCowley
pushed a commit
to nvaccess/nvda
that referenced
this pull request
Jul 18, 2025
Fixes #18460 Fixup of #18354 Summary of the issue: There is a fragile workaround introduced in #18402 (comment). This is also a soft API breakage for add-ons, forcing teleNVDA to use the workaround This is likely a bug fixed in truststore sethmlarson/truststore#149 We are using pip_system_certs to patch in an old version of truststore. this [is no longer being actively maintained](https://gitlab.com/alelec/pip-system-certs/-/issues/27#note_2372267321) and apparently truststore has the same patching feature now. Description of user facing changes: None Description of developer facing changes: Fix workaround which was required for add-ons such as tele NVDA Testing strategy: Ensure #18460 is not reintroduced. Make sure NVDA can still use update check and the add-on store in corporate network environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: pypa/pip#12892 (comment)