Skip to content
This repository was archived by the owner on Feb 16, 2025. It is now read-only.

GoogleVR support#27

Merged
bors-servo merged 17 commits intoservo:masterfrom
Manishearth:gvr
Jul 29, 2019
Merged

GoogleVR support#27
bors-servo merged 17 commits intoservo:masterfrom
Manishearth:gvr

Conversation

@Manishearth
Copy link
Copy Markdown
Member

@Manishearth Manishearth commented Jul 24, 2019

Depends on #25

Not yet finished.

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 24, 2019

☔ The latest upstream changes (presumably #28) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth Manishearth force-pushed the gvr branch 2 times, most recently from 96983b1 to 058da7e Compare July 24, 2019 20:33
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 25, 2019

☔ The latest upstream changes (presumably #29) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth Manishearth force-pushed the gvr branch 4 times, most recently from 797cb33 to d8f5741 Compare July 26, 2019 17:59
@Manishearth Manishearth changed the title [WIP] GoogleVR support GoogleVR support Jul 26, 2019
@Manishearth Manishearth marked this pull request as ready for review July 26, 2019 21:32
@Manishearth
Copy link
Copy Markdown
Member Author

Manishearth commented Jul 26, 2019

Done implementing this. I can't test it until the servo side catches up with webxr master. r? @asajeffrey

@Manishearth Manishearth force-pushed the gvr branch 2 times, most recently from 196ed3c to 2963553 Compare July 26, 2019 21:47
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 27, 2019

☔ The latest upstream changes (presumably #33) made this pull request unmergeable. Please resolve the merge conflicts.

@asajeffrey
Copy link
Copy Markdown
Collaborator

asajeffrey commented Jul 27, 2019

LGTM. Only one more PR to land, then you should be able to test it. Assuming that works OK, r=me.

@Manishearth
Copy link
Copy Markdown
Member Author

Manishearth commented Jul 29, 2019

@bors-servo r=asajeffrey

as discussed in IRC, landing without actually testing so that it doesn't get bitrotten by any churn. At the moment the presence of this backend doesn't affect servo, consider it an experimental backend.

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 29, 2019

📌 Commit b00d879 has been approved by asajeffrey

@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 29, 2019

⌛ Testing commit b00d879 with merge fcbdddb...

bors-servo pushed a commit that referenced this pull request Jul 29, 2019
Auto merge of #27 - Manishearth:gvr, r=asajeffrey
fcbdddb 
GoogleVR support

Depends on #25

Not yet finished.
@bors-servo
Copy link
Copy Markdown
Contributor

bors-servo commented Jul 29, 2019

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing fcbdddb to master...

@bors-servo bors-servo merged commit b00d879 into servo:master Jul 29, 2019
@Manishearth Manishearth deleted the gvr branch August 10, 2019 05:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Manishearth @bors-servo @asajeffrey