Add support for returning displaced entries for re-use.#22
Merged
Conversation
Contributor
Author
|
Here is how the altered method can be used. |
43 tasks
Byron
added a commit
to GitoxideLabs/gitoxide
that referenced
this pull request
Aug 22, 2021
…tions…" This reverts commit 8d49976. Wait for servo/uluru#22 to land.
3 tasks
Collaborator
|
Thanks, this is great. I don't think it needs to be an optional feature, though. You can use I'll merge this PR, and then push a follow-up to make it always use the new method. |
Collaborator
Contributor
Author
|
Absolutely awesome, thank you! Also thanks for removing the feature toggle, there is so much I don't know about |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this to be able to avoid allocations if the entry is allocating, In case of
gitoxidethis saves a couple of millions of allocations in favour of a few thousand re-allocs.Performance wasn't measurably better in my case, just as if the allocator can already repurpose previously freed slabs of memory pretty well or at only a very low cost.
Since it doesn't seem to hurt providing this capability, I am creating this PR anyway in the hopes it does indeed make sense to some in this form or another.
Please let me know :).