Add touch function, Debug and Clone#12
Merged
Merged
Conversation
avitex
commented
Jun 17, 2020
Contributor
- added public touch function based on a predicate
- moved private functions to bottom
- added Debug and Clone support
- renamed LRUCacheMutIterator to IterMut
* added public touch function based on a predicate * moved private functions to bottom * added Debug and Clone support * renamed LRUCacheMutIterator to IterMut
Contributor
Author
|
Reasoning behind touch function was no public functions expose the inner indexes, but I needed a way of touching an entry and getting an immutable reference to its data. I could have |
Contributor
Author
|
Currently blocked on release with this PR, any chance for a review? |
mbrubeck
added a commit
that referenced
this pull request
Jul 17, 2020
* Add `touch` method to moves the matching item to the front (#12). * `LRUCache` now implements `Debug` and `Clone`.
Collaborator
|
This looks great, thanks! I have published a new version that includes these changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.