Conversation
Turns out that since this type is not generic we're paying a lot of function calls in Firefox's optimized builds for no good reason, see: https://perfht.ml/2JuKeMr from: https://bugzilla.mozilla.org/show_bug.cgi?id=1466529 The fact that stuff like inline_bits doesn't get inlined with -O2 is pretty scary over all.
Manishearth
approved these changes
Jun 4, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 4, 2018
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jun 5, 2018
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj
jryans
pushed a commit
to jryans/gecko-dev
that referenced
this pull request
Jun 5, 2018
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj
emilio
added a commit
to emilio/servo
that referenced
this pull request
Jun 11, 2018
Actual code changes reviewed upstream in: servo/smallbitvec#12 Bug: 1466647 MozReview-Commit-ID: 3vKVPMovBj
emilio
added a commit
to emilio/servo
that referenced
this pull request
Jun 12, 2018
Actual code changes reviewed upstream in: servo/smallbitvec#12 Bug: 1466647 MozReview-Commit-ID: 3vKVPMovBj
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj UltraBlame original commit: 103325ca22ce29ec9f493b88b59484589f9252b2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj UltraBlame original commit: 103325ca22ce29ec9f493b88b59484589f9252b2
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj UltraBlame original commit: 103325ca22ce29ec9f493b88b59484589f9252b2
jwidar
pushed a commit
to jwidar/LatencyZeroGithub
that referenced
this pull request
Sep 16, 2025
Actual code changes reviewed upstream in: servo/smallbitvec#12 MozReview-Commit-ID: 3vKVPMovBj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out that since this type is not generic we're paying a lot of function
calls in Firefox's optimized builds for no good reason, see:
https://perfht.ml/2JuKeMr
from:
https://bugzilla.mozilla.org/show_bug.cgi?id=1466529
The fact that stuff like inline_bits doesn't get inlined with -O2 is pretty
scary over all.