SmallBitVec::range method (alternative to impl Index<Range<usize>>)#11
Merged
mbrubeck merged 4 commits intoservo:masterfrom Apr 17, 2018
dbkaplun:vec-methods-range
Merged
SmallBitVec::range method (alternative to impl Index<Range<usize>>)#11mbrubeck merged 4 commits intoservo:masterfrom dbkaplun:vec-methods-range
SmallBitVec::range method (alternative to impl Index<Range<usize>>)#11mbrubeck merged 4 commits intoservo:masterfrom
dbkaplun:vec-methods-range
Conversation
mbrubeck
requested changes
Apr 17, 2018
Collaborator
mbrubeck
left a comment
There was a problem hiding this comment.
Looks good! One suggested change, below:
mbrubeck
reviewed
Apr 17, 2018
src/lib.rs
Outdated
|
|
||
| #[inline] | ||
| fn index(&self, i: usize) -> &bool { | ||
| &self.vec[i + self.range.start] |
Collaborator
There was a problem hiding this comment.
Perhaps this should panic when i + start >= end
mbrubeck
reviewed
Apr 17, 2018
| /// assert_eq!(r[1], true); | ||
| /// ``` | ||
| pub fn range(&self, range: Range<usize>) -> VecRange { | ||
| VecRange { vec: &self, range } |
Collaborator
There was a problem hiding this comment.
This should panic if either end of the range is greater than self.len().
Contributor
Author
|
@mbrubeck ready for review |
mbrubeck
approved these changes
Apr 17, 2018
mbrubeck
added a commit
that referenced
this pull request
Apr 17, 2018
* Added `range` method for slicing a vector by a range of indices (#11) * Some code cleanup and testing improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.