Lowercase DOM getters at compile time, fixes #4728#4815
Merged
bors-servo merged 1 commit intoservo:masterfrom Feb 4, 2015
Merged
Lowercase DOM getters at compile time, fixes #4728#4815bors-servo merged 1 commit intoservo:masterfrom
bors-servo merged 1 commit intoservo:masterfrom
Conversation
|
Thanks for the pull request, and welcome! The Servo team is excited to review your changes, and you should hear from @larsbergstrom (or someone else) soon. |
|
Critic review: https://critic.hoppipolla.co.uk/r/3904 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
The implementation was copied directly from rust-lang/rust#16636 and updated for rust changes, so the credit goes to @Manishearth
dae250f to
02d750a
Compare
bors-servo
pushed a commit
that referenced
this pull request
Feb 3, 2015
The implementation was copied directly from rust-lang/rust#16636 and updated for rust changes, so the credit goes to @Manishearth
bors-servo
pushed a commit
that referenced
this pull request
Feb 3, 2015
The implementation was copied directly from rust-lang/rust#16636 and updated for rust changes, so the credit goes to @Manishearth
Member
|
The tree is broken right now (not your fault), once it gets fixed we'll merge this. |
bors-servo
pushed a commit
that referenced
this pull request
Feb 4, 2015
The implementation was copied directly from rust-lang/rust#16636 and updated for rust changes, so the credit goes to @Manishearth
There was a problem hiding this comment.
Looks like a leftover, or is there something else to do at compile-time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation was copied directly from
rust-lang/rust#16636
and updated for rust changes, so the credit goes to @Manishearth