script: implement missing steps for form submission by TG199 · Pull Request #43700 · servo/servo

TG199 · 2026-03-27T01:26:14Z

Implement missing history handling steps for form submission
Test: ./mach test-wpt tests/wpt/tests/html/semantics/forms/form-submission-0
Fixes: #43670

kkoyung

A few nits.

We usually prefix the PR title with crate you are working on. In this case, replace "feat:" with "script:" in the PR title.

TG199 · 2026-03-27T04:41:42Z

A few nits.

We usually prefix the PR title with crate you are working on. In this case, replace "feat:" with "script:" in the PR title.

I see, I'll make an edit

github-actions · 2026-03-27T05:40:15Z

🔨 Triggering try run (#23632948414) for Linux (WPT)

github-actions · 2026-03-27T06:29:28Z

Test results for linux-wpt from try job (#23632948414):

Flaky unexpected result (29)

OK /_mozilla/css/offset_properties_inline.html (#40543)

FAIL [expected PASS] subtest: offsetTop

assert_equals: offsetTop of #inline-1 should be 0. expected 0 but got -1

FAIL [expected PASS] subtest: offsetLeft

assert_equals: offsetLeft of #inline-2 should be 40. expected 40 but got 25

CRASH [expected OK] /_webgl/conformance2/wasm/readpixels-2gb-in-4gb-wasm-memory.html
OK /content-security-policy/frame-ancestors/frame-ancestors-path-ignored.window.html (#36468)
- PASS [expected FAIL] subtest: A 'frame-ancestors' CSP directive with a URL that includes a path should be ignored.
CRASH [expected OK] /content-security-policy/meta/sandbox-iframe.html (#43478)
FAIL [expected PASS] /css/css-backgrounds/background-size-041.html
TIMEOUT [expected FAIL] /css/css-backgrounds/background-size/vector/wide--auto--omitted-width-omitted-height-viewbox.html
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- FAIL [expected PASS] subtest: Delete layer invalidates @font-face
```
assert_equals: expected "220px" but got "133px"
```
OK /css/css-fonts/variations/at-font-face-font-matching.html (#20684)
- FAIL [expected PASS] subtest: Matching font-weight: '399' should prefer '200 300' over '400'
```
assert_equals: Unexpected font on test element expected 487 but got 532
```
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- FAIL [expected PASS] subtest: moveBefore(): cross-origin iframe is preserved: remove self via innerHTML
```
assert_equals: iframe does not fire a second load event expected 1 but got 0
```
OK /fetch/metadata/generated/css-font-face.https.sub.tentative.html (#32732)
- PASS [expected FAIL] subtest: sec-fetch-dest
- PASS [expected FAIL] subtest: sec-fetch-user
OK /fetch/metadata/window-open.https.sub.html (#40339)
- FAIL [expected PASS] subtest: Same-site window, forced, reloaded
```
The operation is insecure.
```
CRASH [expected OK] /html/anonymous-iframe/worker-cookies.tentative.https.window.html?worker=dedicated_worker
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/semantics/embedded-content/media-elements/media_fragment_seek.html (#24114)
- FAIL [expected PASS] subtest: Video should seek to time specified in media fragment syntax
```
assert_equals: expected 3 but got 0
```
OK [expected TIMEOUT] /html/semantics/embedded-content/media-elements/src_object_blob.html (#40340)
- PASS [expected TIMEOUT] subtest: HTMLMediaElement.srcObject blob
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
CRASH [expected ERROR] /html/semantics/forms/the-select-element/customizable-select/select-appearance-button-after-span.html
OK /html/semantics/scripting-1/the-script-element/module/dynamic-import/blob-url.any.html (#33948)
- FAIL [expected PASS] subtest: Revoking a blob URL immediately after calling import will not fail
```
promise_test: Unhandled rejection with value: object "TypeError: Module fetching failed"
```
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- FAIL [expected PASS] subtest: Cross-Origin video should get upgraded even if CORS is set
```
assert_equals: Length. Other host expected 1 but got Infinity
```
TIMEOUT /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected FAIL] subtest: Navigate a frame via anchor with javascript:-urls in report-only mode.
TIMEOUT [expected OK] /visual-viewport/resize-event-order.html (#41981)
- TIMEOUT [expected FAIL] subtest: Popup: DOMWindow resize fired before VisualViewport.
```
Test timed out
```
- NOTRUN [expected PASS] subtest: iframe: DOMWindow resize fired before VisualViewport.
OK /webdriver/tests/classic/element_click/center_point.py
- FAIL [expected PASS] subtest: test_entirely_in_view
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/element_click/file_upload.py
- FAIL [expected PASS] subtest: test_file_upload_state
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/execute_script/window.py
- FAIL [expected PASS] subtest: test_web_reference[frame]
```
AssertionError: no such window (404): No such window
```
OK /webdriver/tests/classic/find_elements_from_shadow_root/find.py
- FAIL [expected PASS] subtest: test_null_parameter_value
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK /webdriver/tests/classic/get_element_rect/user_prompts.py
- FAIL [expected PASS] subtest: test_accept[alert-None]
```
webdriver.error.NoSuchWindowException: no such window (404): No such window
```
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
CRASH [expected OK] /xhr/access-control-and-redirects.any.worker.html

Stable unexpected results that are known to be intermittent (13)

FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```

ERROR [expected CRASH] /_webgl/conformance2/textures/misc/tex-3d-size-limit.html (#42881)

PASS [expected FAIL] subtest: WebGL test #1

FAIL [expected PASS] subtest: WebGL test #3

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #4

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #5

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #6

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #7

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #8

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #9

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #10

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

FAIL [expected PASS] subtest: WebGL test #11

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : texImage3D should fail for dimension out of range. expected true got false

And 27 more unexpected results...

OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
```
assert_equals: quoted cursive matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted fantasy (drawing text in a canvas)
```
assert_equals: quoted fantasy matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted monospace (drawing text in a canvas)
```
assert_equals: quoted monospace matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted system-ui (drawing text in a canvas)
```
assert_equals: quoted system-ui matches  @font-face rule expected 125 but got 40
```
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(nastaliq) (drawing text in a canvas)
```
assert_equals: quoted generic(nastaliq) matches  @font-face rule expected 125 but got 40
```
ERROR [expected OK] /fetch/fetch-later/quota/same-origin-iframe/accumulated-oversized-payload.https.window.html (#41705)
ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-initial-navigation.html (#40387)

OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)

FAIL [expected PASS] subtest: aElement.click() before the load event must NOT replace

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20a%20%3D%20document.createElement(%22a%22)%3B%0A%20%20%20%20a.href%20%3D%20%22%2Fcommon%2Fblank.html%3Fthereplacement%22%3B%0A%20%20%20%20document.currentScript.before(a)%3B%0A%20%20%20%20a.click()%3B%0A%20%20"

OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
OK /html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/allow-scripts-flag-changing-2.html (#39703)
- FAIL [expected PASS] subtest: Meta refresh of the original iframe is not blocked if moved into a sandboxed iframe
```
uncaught exception: Error: assert_unreached: The iframe into which the meta was moved must not refresh Reached unreachable code
```
OK /html/semantics/embedded-content/media-elements/audio_loop_seek_to_eos.html (#41226)
- PASS [expected FAIL] subtest: seeking to the end of looping audio
OK /resource-timing/buffer-full-add-then-clear.html (#40819)
- FAIL [expected PASS] subtest: Test that if the buffer is cleared after entries were added to the secondary buffer, those entries make it into the primary one
```
assert_equals: Number of entries does not match the expected value. expected 3 but got 0
```
CRASH [expected OK] /resource-timing/render-blocking-status-link.html (#41664)

Stable unexpected results (9)

TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit-during-load.html
- TIMEOUT [expected FAIL] subtest: Replace during the load event, triggered by formElement.submit()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit-during-pageshow.html
- TIMEOUT [expected FAIL] subtest: Replace during the pageshow event, triggered by formElement.submit()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click-during-load.html
- TIMEOUT [expected FAIL] subtest: Replace during load, triggered by submitButton.click()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click-during-pageshow.html
- TIMEOUT [expected FAIL] subtest: Replace during pageshow, triggered by submitButton.click()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-button-click.html
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by submitButton.click()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-during-load.html
- TIMEOUT [expected FAIL] subtest: Replace during the load event, triggered by formElement.submit()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit-during-pageshow.html
- TIMEOUT [expected FAIL] subtest: Replace during the pageshow event, triggered by formElement.submit()
```
Test timed out
```
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html
- TIMEOUT [expected FAIL] subtest: Replace before load, triggered by same-document formElement.submit()
```
Test timed out
```
OK /html/browsers/history/the-session-history-of-browsing-contexts/navigation-in-onload.html
- PASS [expected FAIL] subtest: Navigation in onload handler

github-actions · 2026-03-27T06:29:36Z

⚠️ Try run (#23632948414) failed!

kkoyung · 2026-03-28T05:17:11Z

⚠️ Try run (#23632948414) failed!

Also update the test expectation according to the report.

TG199 · 2026-03-28T05:22:35Z

⚠️ Try run (#23632948414) failed!

Also update the test expectation according to the report.

Okay

kkoyung · 2026-03-31T08:05:12Z

-        let history_handling = if doc == target_document && !doc.completely_loaded() {
+        let history_handling = if std::ptr::eq(&*doc as *const _, &*target_document as *const _) &&
+            !doc.completely_loaded()
+        {


Is there any particular reason to switch from using == to comparing the pointer instead, at the last commit?

Okay so while updating test expectations, I noticed jsurl-form-submit.tentative.html was failing and history_handling was becoming Replace when it should be Auto. Suspecting == on DomRoot wasn't doing pointer equality, so I tried std::ptr::eq instead to see what happens.

They do that already:

servo/components/script_bindings/root.rs

Line 173 in 54bc366

self.ptr.as_ptr() == other.ptr.as_ptr()

Oh okay, thanks for the clarification! I'll revert back to ==. I'm still not sure why jsurl-form-submit.tentative.html was failing though, is that a pre-existing issue or something my change introduced?

I'm confused—the changes in this PR make it look like the test is passing since we're removing the ini file. Do you see different results locally?

jdm · 2026-04-02T14:18:31Z

@TG199 Could you look into the tests that are now timing out like /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html? You can use https://book.servo.org/contributing/guides/diagnosing-errors/stable-wpt-errors.html?highlight=Timeo#diagnosing-a-timeout-result for inspiration.

TG199 · 2026-04-02T21:22:59Z

Hi @jdm I've confirmed this is a regression from my change. On main the test passes but on my branch it times out. The test submits a form inside an iframe while it's still loading. My step 25 sets history_handling = Replace for this case, but something about how navigate() handles an explicit Replace (vs Auto resolving to Replace) causes the navigation to stall. I've traced it to navigation.rs but I'm not sure what the correct fix is. Should step 25 use a different approach, or is there something in how navigate handles Replace for not-yet-loaded iframes that needs fixing?

jdm · 2026-04-02T22:11:24Z

What's the step in the test that times out? I'm assuming it's waiting for some event.

TG199 · 2026-04-02T23:29:52Z

The timeout is in checkSentinelIframe, specifically await waitForLoad(t, sentinelIframe, "/common/blank.html?sentinelstart") after history.back(). The sentinel iframe's load event never fires after calling history.back()

jdm · 2026-04-03T01:02:03Z

The sentinel iframe's load event never fires after calling history.back()

This is very helpful! That looks like a preexisting bug in Servo that I've been able to reproduce, so I'm going to file a new issue for that.

TG199 · 2026-04-03T01:47:27Z

The sentinel iframe's load event never fires after calling history.back()

This is very helpful! That looks like a preexisting bug in Servo that I've been able to reproduce, so I'm going to file a new issue for that.

Okay

kkoyung · 2026-04-03T15:28:08Z

Since the timeout is related to another bug, we can fix it separately. Apart from that, the PR looks good to me.

@TG199 Could you update the test expectation so that we can run the tests once more on our CI?

The ./mach update-wpt command is useful to update multiple expectation. https://book.servo.org/contributing/testing.html#updating-web-platform-test-expectations

These are the related tests:
tests/wpt/tests/html/semantics/forms/form-submission-0
tests/wpt/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load
tests/wpt/tests/html/browsers/history/the-session-history-of-browsing-contexts

TG199 · 2026-04-04T05:23:04Z

Since the timeout is related to another bug, we can fix it separately. Apart from that, the PR looks good to me.

@TG199 Could you update the test expectation so that we can run the tests once more on our CI?

The ./mach update-wpt command is useful to update multiple expectation. https://book.servo.org/contributing/testing.html#updating-web-platform-test-expectations

These are the related tests: tests/wpt/tests/html/semantics/forms/form-submission-0 tests/wpt/tests/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load tests/wpt/tests/html/browsers/history/the-session-history-of-browsing-contexts

Thank you for pointing out the related test directories! I've updated the expectations and pushed.
How did you identify those related test directories? I'd like to know how to find them myself for future contributions.

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

… comparison Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

TG199 · 2026-04-09T19:37:19Z

@jdm is this good as is?

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

github-actions · 2026-04-10T17:03:10Z

🔨 Triggering try run (#24254482947) for Linux (WPT)

github-actions · 2026-04-10T18:13:08Z

Test results for linux-wpt from try job (#24254482947):

Flaky unexpected result (26)

OK [expected TIMEOUT] /_webgl/conformance/textures/misc/tex-video-using-tex-unit-non-zero.html (#39735)
- PASS [expected NOTRUN] subtest: Overall test
- PASS [expected FAIL] subtest: WebGL test #0

OK /_webgl/conformance/textures/misc/texture-upload-size.html (#21770)

FAIL [expected PASS] subtest: WebGL test #45

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #47

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

FAIL [expected PASS] subtest: WebGL test #49

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #51

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

PASS [expected FAIL] subtest: WebGL test #53
PASS [expected FAIL] subtest: WebGL test #55
PASS [expected FAIL] subtest: WebGL test #57
PASS [expected FAIL] subtest: WebGL test #59

FAIL [expected PASS] subtest: WebGL test #61

assert_true: Texture was smaller than the expected size 2x2 expected true got false

FAIL [expected PASS] subtest: WebGL test #63

assert_true: getError expected: INVALID_VALUE. Was NO_ERROR : when calling texSubImage2D with the same texture upload with offset 1, 1 expected true got false

And 14 more unexpected results...

OK /cookies/partitioned-cookies/partitioned-cookies-samesite-attribute.https.html
- FAIL [expected PASS] subtest: In embedded cross-site contexts, partitioned cookies can only be set with explicit SameSite=None
```
assert_equals: expected 0 but got 3
```
TIMEOUT [expected OK] /credential-management/credentialscontainer-frame-basics.https.html (#39430)
- TIMEOUT [expected FAIL] subtest: navigator.credentials should be undefined in documents generated from data: URLs.
```
Test timed out
```
OK /css/css-cascade/layer-cssom-order-reverse.html (#36094)
- FAIL [expected PASS] subtest: Delete layer invalidates @font-face
```
assert_equals: expected "220px" but got "133px"
```
TIMEOUT [expected OK] /fetch/api/redirect/redirect-keepalive.https.any.html (#32153)
- TIMEOUT [expected PASS] subtest: [keepalive][iframe][load] mixed content redirect; setting up
```
Test timed out
```
ERROR [expected TIMEOUT] /html/browsers/browsing-the-web/history-traversal/pageswap/pageswap-initial-navigation.html (#40387)
OK /html/browsers/browsing-the-web/navigating-across-documents/005.html (#27062)
- FAIL [expected PASS] subtest: Link with onclick navigation and href navigation
```
assert_equals: expected "href" but got "click"
```
CRASH [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/javascript-url-global-scope.html
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-cross-origin.sub.window.html (#29056)
- PASS [expected FAIL] subtest: Cross-origin navigation started from unload handler must be ignored

OK /html/browsers/browsing-the-web/navigating-across-documents/refresh/same-document-refresh.html (#34597)

FAIL [expected PASS] subtest: Same-Document Referrer from Refresh

assert_equals: original page loads expected "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/refresh/resources/refresh-with-section.sub.html?url=%23section#section"

OK [expected TIMEOUT] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-requestsubmit.html

FAIL [expected TIMEOUT] subtest: Replace before load, triggered by formElement.requestSubmit()

assert_equals: expected "http://web-platform.test:8000/common/blank.html?thereplacement=" but got "http://web-platform.test:8000/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/resources/code-injector.html?pipe=sub(none)&amp;code=%0A%20%20%20%20const%20form%20%3D%20document.createElement(%22form%22)%3B%0A%20%20%20%20form.action%20%3D%20%22%2Fcommon%2Fblank.html%22%3B%0A%0A%20%20%20%20const%20input%20%3D%20document.createElement(%22input%22)%3B%0A%20%20%20%20input.type%20%3D%20%22hidden%22%3B%0A%20%20%20%20input.name%20%3D%20%22thereplacement%22%3B%0A%20%20%20%20form.append(input)%3B%0A%0A%20%20%20%20document.currentScript.before(form)%3B%0A%20%20%20%20form.requestSubmit()%3B%0A%20%20"

OK /html/browsers/history/the-history-interface/traverse_the_history_5.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected OK] /html/browsers/the-window-object/window-open-noopener.html?_top
CRASH [expected TIMEOUT] /html/canvas/offscreen/text/2d.text.measure.fillTextCluster-baseline.tentative.w.html
ERROR [expected OK] /html/canvas/offscreen/text/2d.text.measure.getActualBoundingBox.tentative.html (#43710)
TIMEOUT [expected OK] /html/interaction/focus/the-autofocus-attribute/document-with-fragment-empty.html (#28259)
- TIMEOUT [expected FAIL] subtest: Autofocus elements in top-level browsing context's documents with empty fragments should work.
```
Test timed out
```
OK /html/semantics/embedded-content/media-elements/playing-the-media-resource/loop-from-ended.tentative.html (#33778)
- FAIL [expected PASS] subtest: play() with loop set to true after playback ended
```
this argument is not a finite floating-point value
```
TIMEOUT [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_navigate_other_frame_popup.sub.html (#39702)
- TIMEOUT [expected FAIL] subtest: Sandboxed iframe can not navigate other frame's popup
```
Test timed out
```
CRASH [expected ERROR] /html/semantics/forms/the-select-element/customizable-select/select-appearance-button-after-span.html
TIMEOUT [expected OK] /html/user-activation/navigation-state-reset-sameorigin.html
- TIMEOUT [expected PASS] subtest: Post-navigation state reset.
```
Test timed out
```
OK /pointerevents/compat/pointerevent_touch_target_after_pointerdown_target_removed.tentative.html (#42813)
- PASS [expected FAIL] subtest: After a pointerdown listener moves the target to different position, touch events should be fired on the pointerdown target, but pointer events should be fired on the pointerdown target parent
- PASS [expected FAIL] subtest: After a pointerdown listener moves the target to different position, touchmove event should be fired on the pointerdown target parent
TIMEOUT [expected OK] /preload/modulepreload-sri.html
- TIMEOUT [expected PASS] subtest: Script should not be loaded if modulepreload's integrity is invalid
```
Test timed out
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?06-10 (#37920)
- PASS [expected TIMEOUT] subtest: Navigate a frame via anchor with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?31-35 (#38034)
- PASS [expected TIMEOUT] subtest: Navigate a frame via form-submission with javascript:-urls w/ default policy in report-only mode.
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy throwing an exception in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- FAIL [expected NOTRUN] subtest: Navigate a window via form-submission with javascript:-urls w/ a default policy making the URL invalid in enforcing mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
CRASH [expected OK] /webaudio/the-audio-api/the-mediastreamaudiodestinationnode-interface/closed-audiocontext-construction.html

Stable unexpected results that are known to be intermittent (20)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- PASS [expected TIMEOUT] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-cascade/layer-font-face-override.html (#35935)
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 1
- PASS [expected FAIL] subtest: @font-face override update with appended sheet 2
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted generic(khmer-mul)
```
assert_equals: quoted generic(khmer-mul) matches  @font-face rule expected 50 but got 30
```
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted cursive (drawing text in a canvas)
```
assert_equals: quoted cursive matches  @font-face rule expected 125 but got 40
```
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong) (drawing text in a canvas)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted ui-sans-serif (drawing text in a canvas)
OK /dom/nodes/moveBefore/iframe-document-preserve.window.html (#43152)
- PASS [expected FAIL] subtest: moveBefore(): cross-origin iframe is preserved: remove self
OK [expected ERROR] /fetch/fetch-later/quota/same-origin-iframe/multiple-iframes.https.window.html (#35176)
TIMEOUT [expected OK] /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html (#44028)
OK /html/browsers/history/the-history-interface/traverse_the_history_4.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
CRASH [expected TIMEOUT] /html/browsers/history/the-location-interface/location_replace_session_history.html (#41896)
TIMEOUT /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)
- PASS [expected TIMEOUT] subtest: Non-HTMLElement should not support autofocus
- FAIL [expected NOTRUN] subtest: Host element with delegatesFocus should support autofocus
```
assert_equals: expected Element node &lt;div autofocus=""&gt;&lt;/div&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;/body&gt;
```
- TIMEOUT [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped
```
Test timed out
```

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /mixed-content/tentative/autoupgrades/mixed-content-cors.https.sub.html (#41123)
- PASS [expected FAIL] subtest: Cross-Origin video should get upgraded even if CORS is set
OK /navigation-timing/test-navigation-type-reload.html (#33334)
- FAIL [expected PASS] subtest: Reload domContentLoadedEventEnd > Original domContentLoadedEventEnd
```
assert_true: Reload domContentLoadedEventEnd &gt; Original domContentLoadedEventEnd expected true got false
```
- FAIL [expected PASS] subtest: Reload domContentLoadedEventStart > Original domContentLoadedEventStart
```
assert_true: Reload domContentLoadedEventStart &gt; Original domContentLoadedEventStart expected true got false
```
OK /resource-timing/test_resource_timing.https.html (#25216)
- PASS [expected FAIL] subtest: PerformanceEntry has correct name, initiatorType, startTime, and duration (img)
OK /touch-events/single-tap-when-touchend-listener-use-sync-xhr.html (#41175)
- FAIL [expected PASS] subtest: Click event should be fired when touchend opens synchronous XHR
```
assert_equals: expected "touchend@div, mousedown@div, mouseup@div, click@div" but got "touchend@div, mousedown@div"
```
OK [expected TIMEOUT] /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected TIMEOUT] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a window via anchor with javascript:-urls w/ default policy in report-only mode.
- PASS [expected NOTRUN] subtest: Navigate a frame via anchor with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-reporting.html (#43737)
- PASS [expected FAIL] subtest: Trusted Type violation report: creating a forbidden-but-not-reported policy.
- PASS [expected FAIL] subtest: Trusted Type violation report: sample for SVGScriptElement href assignment by setAttribute
OK [expected TIMEOUT] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- PASS [expected TIMEOUT] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe

github-actions · 2026-04-10T18:13:30Z

✨ Try run (#24254482947) succeeded.

TG199 requested a review from gterzian as a code owner March 27, 2026 01:26

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Mar 27, 2026

kkoyung requested changes Mar 27, 2026

View reviewed changes

Comment thread tests/wpt/meta/html/semantics/forms/form-submission-0/jsurl-form-submit.tentative.html.ini

Comment thread components/script/dom/html/htmlformelement.rs

servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Mar 27, 2026

TimvdLippe added the T-linux-wpt Do a try run of the WPT label Mar 27, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Mar 27, 2026

TG199 changed the title ~~feat: implement missing steps for form submission~~ script: implement missing steps for form submission Mar 27, 2026

servo-highfive added S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. S-needs-rebase There are merge conflict errors. labels Mar 27, 2026

kkoyung reviewed Mar 28, 2026

View reviewed changes

Comment thread components/script/dom/html/htmlformelement.rs Outdated

kkoyung reviewed Mar 31, 2026

View reviewed changes

TG199 force-pushed the Implement_missing_history_handling_steps_for_form_submission branch from f195a41 to 7b01eb5 Compare April 2, 2026 10:24

TG199 requested a review from kkoyung April 2, 2026 11:49

TG199 mentioned this pull request Apr 8, 2026

/html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/form-submit.html intermittently times out #44028

Open

TG199 force-pushed the Implement_missing_history_handling_steps_for_form_submission branch from e637e22 to 698e299 Compare April 9, 2026 05:43

TG199 added 12 commits April 9, 2026 13:58

feat: implement missing steps for form submission

646c950

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Remove .ini file

5633278

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Fix clippy error

a085d93

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

change history handling logic, use std::ptr::eq for document identity…

85bcb29

… comparison Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Revert to == for document comparison

7a494f5

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

fix delimeter

609b3bd

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Update WPT expectations

c803f06

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Update WPT expectations for replace-before-load timeouts

cf42cc2

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Update WPT expectations: FAIL -> TIMEOUT for replace-before-load tests

82f7025

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Update WPT sub test expectations: FAIL -> TIMEOUT

6e25669

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Update WPT expectations for replace-before-load and navigation-in-onload

d2ae70b

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

Fix form-submit.html expectation: remove test-level TIMEOUT

fb693d8

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

TG199 force-pushed the Implement_missing_history_handling_steps_for_form_submission branch from 698e299 to fb693d8 Compare April 9, 2026 13:00

kkoyung reviewed Apr 10, 2026

View reviewed changes

Comment thread ...html/browsers/history/the-session-history-of-browsing-contexts/navigation-in-onload.html.ini Outdated

Remove navigation-in-onload.html.ini as test now passes

fdb3e18

Signed-off-by: Kelechi Ebiri <ebiritg@gmail.com>

kkoyung approved these changes Apr 10, 2026

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Apr 10, 2026

jdm added the T-linux-wpt Do a try run of the WPT label Apr 10, 2026

github-actions Bot removed the T-linux-wpt Do a try run of the WPT label Apr 10, 2026

jdm added this pull request to the merge queue Apr 10, 2026

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 10, 2026

Merged via the queue into servo:main with commit a670c7a Apr 10, 2026
68 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Apr 10, 2026

Uh oh!

Conversation

TG199 commented Mar 27, 2026

Uh oh!

kkoyung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TG199 commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

github-actions Bot commented Mar 27, 2026

Uh oh!

Uh oh!

kkoyung commented Mar 28, 2026

Uh oh!

TG199 commented Mar 28, 2026

Uh oh!

kkoyung Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

TG199 Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

jdm Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

TG199 Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdm Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jdm commented Apr 2, 2026

Uh oh!

TG199 commented Apr 2, 2026

Uh oh!

jdm commented Apr 2, 2026

Uh oh!

TG199 commented Apr 2, 2026

Uh oh!

jdm commented Apr 3, 2026

Uh oh!

TG199 commented Apr 3, 2026

Uh oh!

kkoyung commented Apr 3, 2026

Uh oh!

TG199 commented Apr 4, 2026

Uh oh!

TG199 commented Apr 9, 2026

Uh oh!

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

github-actions Bot commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

TG199 Mar 31, 2026 •

edited

Loading

jdm Apr 2, 2026 •

edited

Loading