script: Support new context for promise and add some more helpers to ease migration #41520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 27, 2025
Continuation of #41520 to use more safe cx in promises, now by passing &mut CurrentRealm in callbacks. Most callback implementations still do conversions to old SafeJSContext, so there are some low hanging stuff for follow ups. Testing: Should be covered by existing WPT tests. try run: https://github.com/sagudev/servo/actions/runs/20540030020 Part of #40600 --------- Signed-off-by: sagudev <16504129+sagudev@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using new JSContext/CurrentRealm to promise and adds some more helpers that will ease migration to new context model. Second commit has another demo.
Testing: Covered by WPT
Part of #40600