script: add CanGc as argument to methods in HTMLOptionElement #40873
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jdm Here is one for HTMLOptionElement |
Member
|
@yerke Thank you! I'll merge this PR, but we're going to put a pause on further CanGc work like this, since we have a replacement API that makes the JS API safer and more precise about whether a particular API call can trigger a GC or not. If you want to help with that effort instead, it would be really useful! See servo/mozjs#647 for more info. |
jdm
approved these changes
Nov 25, 2025
Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
auto-merge was automatically disabled
November 25, 2025 03:51
Head branch was pushed to by a user without write access
2e41adc to
f12adca
Compare
Contributor
Author
|
Sorry, I forgot to run tidy before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
script: add CanGc as argument to methods in HTMLOptionElement
Testing: These changes do not require tests because they are a refactor.
Addresses part of #34573