-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Closed
Labels
B-metaThis issue tracks the status of multiple, related pieces of workThis issue tracks the status of multiple, related pieces of workE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.
Description
As part of #33140, I propose we use this as a meta issue to track functions that still need to be updated to take a can_gc argument, and adding those seem to me like good tasks for new contributors. I'm starting here with only one.
For an example, see #33960
List of function or methods that need a can_gc: CanGC argument:
-
enter_realm - Promise::resolve (JS::ResolvePromise)
- Promise::reject (JS::RejectPromise)
- Promise::resolve_native
- Promise::reject_native
- Promise::reject_error
- Promise::new_resolved
- Promise::new_rejected
- WindowProxy::set_window (JS_TransplantObject)
- SubtleCrypto::generate_key_aes (JS_NewObject)
- SubtleCrypto::generate_key_hmac
- SubtleCrypto::import_key_aes
- SubtleCrypto::import_key_hkdf
- SubtleCrypto::import_key_hmac
- SubtleCrypto::import_key_pbkdf2
- create_buffer_source (TypedArray::create)
- create_buffer_source_with_length
- DataBlock::view (NewExternalArrayBuffer)
- exception_to_promise
- extract_size_algorithm
- CountQueueingStrategy::GetSize
- ByteLengthQueueingStrategy::GetSize
Metadata
Metadata
Assignees
Labels
B-metaThis issue tracks the status of multiple, related pieces of workThis issue tracks the status of multiple, related pieces of workE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.