-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ohos CI: Try and improve the scenario test stability #40841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ohos CI: Try and improve the scenario test stability #40841
Conversation
Previously enabling the performance mode helped preventing time-outs in the speedometer test on hos devices. This functionality was extracted into a seperate python library, and we try and apply it to the scenario tests too. Internally this use `hdc shell power-shell` to set the - performance mode - screen timeout - explicit wakeup of the device After the test / on exception, the changes performance mode is disabled again (hence the `with``. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Move some common setup code into a common function. Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Take a screenshot on errors Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
yezhizhen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup.
| stop_servo() | ||
| sys.exit(1) | ||
| try: | ||
| with HarmonyDevicePerfMode(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should enter PerfMode earlier; or even always on. No strong opinions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More testing needed to come to a conclusive answer, but I think it might need to be after starting the app (like it is now), or alternatively add a step to somehow unlock the Lockscreen.
|
🔨 Triggering try run (#19621857753) for OpenHarmony |
|
✨ Try run (#19621857753) succeeded. |
|
🔨 Triggering try run (#19622195132) for OpenHarmony |
|
✨ Try run (#19622195132) succeeded. |
…inux-wpt-2020)
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
…inux-wpt-2020)
{"fail_fast": false, "matrix": [{"name": "Linux (WPT)", "workflow": "linux", "wpt": true, "profile": "release", "unit_tests": false, "build_libservo": false, "bencher": false, "coverage": false, "build_args": "", "wpt_args": "", "number_of_wpt_chunks": 20}]}
hdc_pylibrary, used for enabling (and disabling) performance mode and screen timeout.The performance mode / screen timeout should hopefully help with the timeouts, or at least the screenshots might help show what's going wrong.
Testing: This is a CI modification for ohos. mach try