Skip to content

Conversation

@kkoyung
Copy link
Member

@kkoyung kkoyung commented Nov 23, 2025

Implements digest operation of CShake, including cSHAKE128 and cSHAKE256, using the crate sha3 and digest for the CShake calculation.

Testing: Pass WPT tests that were expected to fail.
Fixes: Part of #40687

Implements digest operation of CShake, including `cSHAKE128` and
`cSHAKE256`, using the crate `sha3` and `digest` for the CShake
calculation.

Testing: Pass WPT tests that were expected to fail.
Fixes: Part of 40687

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung kkoyung requested a review from gterzian as a code owner November 23, 2025 05:28
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 23, 2025
@jdm jdm added this pull request to the merge queue Nov 23, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 23, 2025
github-merge-queue bot pushed a commit that referenced this pull request Nov 23, 2025
Implements digest operation of CShake, including `cSHAKE128` and
`cSHAKE256`, using the crate `sha3` and `digest` for the CShake
calculation.

Testing: Pass WPT tests that were expected to fail.
Fixes: Part of #40687

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 23, 2025
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 23, 2025
@jdm jdm added this pull request to the merge queue Nov 23, 2025
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 23, 2025
Merged via the queue into servo:main with commit d380d0a Nov 23, 2025
41 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 23, 2025
@kkoyung kkoyung deleted the cshake branch December 3, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants