Skip to content

script: Finish converting all error message enum variants to Option<String> #40750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sagudev merged 1 commit into from
Nov 20, 2025
Merged

script: Finish converting all error message enum variants to Option<String> #40750

sagudev merged 1 commit into from
Nov 20, 2025

Conversation

@arihant2math
Copy link
Contributor

@arihant2math arihant2math commented Nov 20, 2025 •
edited
Loading

I used find and replace to finish the job. All this PR does is replace all Error::<error_name> occurrences with Error::<error_name>(None).

Testing: Refactor
Fixes: #39053

@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. S-needs-rebase There are merge conflict errors. labels Nov 20, 2025
@arihant2math
finish converting all strings to Option<String>
c1099cb 
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@servo-highfive servo-highfive removed the S-needs-rebase There are merge conflict errors. label Nov 20, 2025
@arihant2math arihant2math added S-awaiting-review There is new code that needs to be reviewed. and removed S-awaiting-review There is new code that needs to be reviewed. labels Nov 20, 2025
@mrobinson mrobinson changed the title sciprt: Finish converting all error message enum variants to Option<String> script: Finish converting all error message enum variants to Option<String> Nov 20, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 20, 2025
@sagudev sagudev added this pull request to the merge queue Nov 20, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2025
@servo-highfive servo-highfive added S-tests-failed The changes caused existing tests to fail. and removed S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. labels Nov 20, 2025
@sagudev sagudev added this pull request to the merge queue Nov 20, 2025
@servo-highfive servo-highfive added S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. and removed S-tests-failed The changes caused existing tests to fail. labels Nov 20, 2025
Merged via the queue into servo:main with commit e0eb23c Nov 20, 2025
42 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
@arihant2math arihant2math deleted the error-strings branch November 20, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sagudev sagudev sagudev approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provide messages in JS errors

3 participants

@arihant2math @sagudev @servo-highfive