-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Labels
A-content/bindingsThe DOM bindingsThe DOM bindingsA-content/domInteracting with the DOM from web contentInteracting with the DOM from web contentE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.
Description
Browser always report message with errors, but in servo we only do messages for type and range errors. I think we should start writing actual error messages.
The first step towards it is to add Option<String> field to each variant in
servo/components/script_bindings/error.rs
Line 15 in 91b2ab5
| pub enum Error { |
I suggest one for each PR (as we need to fix all occurrences to pass None and eventually build actual errors). See #39056 for example of such PR.
- IndexSize
- NotFound
- HierarchyRequest
- WrongDocument
- InvalidCharacter
- NotSupported
- InUseAttribute
- InvalidState
- Syntax (script: Add message to SyntaxError #39056)
- Namespace
- InvalidAccess
- Security
- Network
- Abort
- Timeout
- InvalidNodeType
- TransactionInactive
- ReadOnly
- Version
- NoModificationAllowed
- TypeMismatch
- InvalidModification
- NotReadable
- Data
- Operation
- NotAllowed
- Encoding
- Constraint
Metadata
Metadata
Assignees
Labels
A-content/bindingsThe DOM bindingsThe DOM bindingsA-content/domInteracting with the DOM from web contentInteracting with the DOM from web contentE-less-complexStraightforward. Recommended for a new contributor.Straightforward. Recommended for a new contributor.