Skip to content

script: Add message to Dom exception Error::NotSupported #40745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yezhizhen merged 1 commit into from
Nov 20, 2025
Merged

script: Add message to Dom exception Error::NotSupported #40745

yezhizhen merged 1 commit into from
Nov 20, 2025

Conversation

@d-kraus
Copy link
Contributor

@d-kraus d-kraus commented Nov 19, 2025 •
edited by yezhizhen
Loading

Adding an optional message to Error::NotSupported. Unblocks #39050.

The enum definition of NotSupported is now NotSupported(Option<String>).

Testing: Just a refactor
Fixes: Partially #39053

@d-kraus
script: Add Message to NotSupported
d87a36e 
Signed-off-by: Dennis Kraus <kraus@posteo.de>
@d-kraus d-kraus requested a review from gterzian as a code owner November 19, 2025 21:19
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 19, 2025
@yezhizhen yezhizhen changed the title script: Add Message to NotSupported script: Add Message to Dom Exception Error::NotSupported Nov 20, 2025
@yezhizhen yezhizhen changed the title script: Add Message to Dom Exception Error::NotSupported script: Add message to Dom exception Error::NotSupported Nov 20, 2025
@yezhizhen yezhizhen enabled auto-merge November 20, 2025 01:19
@yezhizhen yezhizhen added this pull request to the merge queue Nov 20, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
Merged via the queue into servo:main with commit adf840a Nov 20, 2025
37 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yezhizhen yezhizhen yezhizhen approved these changes

@gterzian gterzian Awaiting requested review from gterzian gterzian is a code owner

+1 more reviewer

@arihant2math arihant2math arihant2math approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@d-kraus @yezhizhen @arihant2math @servo-highfive