libservo: Add WebView::can_go_forward and WebView::can_go_back
#40598
+198
−86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukilan
approved these changes
Nov 12, 2025
| /// Whether the location has been edited by the user without clicking Go. | ||
| location_dirty: bool, | ||
|
|
||
| /// The [`LoadStatus`] of the active `WebView. |
Member
There was a problem hiding this comment.
Suggested change
| /// The [`LoadStatus`] of the active `WebView. | |
| /// The [`LoadStatus`] of the active `WebView`. |
components/servo/webview.rs
Outdated
| cursor: Cursor, | ||
|
|
||
| /// The back / forward list of this WebView. | ||
| back_foward_list: Vec<Url>, |
Member
There was a problem hiding this comment.
Suggested change
| back_foward_list: Vec<Url>, | |
| back_forward_list: Vec<Url>, |
These two new API method make it easier to enable and disable the back and forward buttons in the browser UI. In addition, they are used to enable and disable the context menu items for "Back" and "Forward". This is something that is much, much easier to do in the embedding layer, rather than in script. In addition, the new methods are wired up to the buttons in Servoshell. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
bb82707 to
571a384
Compare
Member
Author
|
@mukilan Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two new API method make it easier to enable and disable the back
and forward buttons in the browser UI. In addition, they are used to
enable and disable the context menu items for "Back" and "Forward". This
is something that is much, much easier to do in the embedding layer,
rather than in script.
In addition, the new methods are wired up to the buttons in Servoshell.
Testing: This change includes a new API test.