Skip to content

Conversation

@kkoyung
Copy link
Member

@kkoyung kkoyung commented Nov 10, 2025

Start adding ECDSA support to WebCrypto API. This patch implements import key operation of ECDSA, using ECDSA implementation from the crates p256, p384, p521 and elliptic_curve.

Testing:

  • Pass some WPT tests that were expected to fail.
  • Remaining failed tests in ec_importKey.https.any.js.ini require the not-yet-implemented export key operation of ECDSA.
  • The new FAIL expectations are added to ecdsa.https.any.js.ini, which require the not-yet-implemented sign/verify operations of ECDSA. These tests were skipped by WPT because the import key operation had not been implemented at the time.

Fixes: Part of #39060

Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev>
@kkoyung kkoyung requested a review from gterzian as a code owner November 10, 2025 05:31
@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Nov 10, 2025
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 10, 2025
@TimvdLippe TimvdLippe added this pull request to the merge queue Nov 10, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 10, 2025
Merged via the queue into servo:main with commit 885b404 Nov 10, 2025
35 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 10, 2025
@kkoyung kkoyung deleted the ecdsa-import branch November 10, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants