net: Do not implement Serialize/Deserialize for RasterImage and introduce`SharedRasterImage
#40459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d86d9e to
c1a4e39
Compare
mrobinson
requested changes
Nov 6, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Looks good, just a few minor comments...
| pub icon_url: Option<ServoUrl>, | ||
| /// Icon's raw image data and metadata. | ||
| pub icon_resource: Option<Arc<RasterImage>>, | ||
| pub icon_resource: Option<Arc<SharedRasterImage>>, |
Member
There was a problem hiding this comment.
I would leave all of these types as RasterImage but implement a From<SharedRasterImage> for RasterImage and just call into() when filling these fields.
Contributor
Author
There was a problem hiding this comment.
The notification is Serializable, so I think we need to keep this SharedRasterImage.
Add a new struct `SharedRasterImage` that allows serializeing. This can be constructed from RasterImage. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
Signed-off-by: Narfinger <Narfinger@users.noreply.github.com>
c1a4e39 to
3296850
Compare
Serialize/Deserialize for RasterImage and introduce`SharedRasterImage
mrobinson
approved these changes
Nov 7, 2025
Member
mrobinson
left a comment
There was a problem hiding this comment.
Let's give this a shot. If we notice a large performance regression we can revert it. I think we have eliminated a few copies in the image code already, so I'm pretty sure this is okay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RasterImage is now not seralizeable and backed by Vec storage. Add a new struct
SharedRasterImagethat allows serializeing. This can be constructed from RasterImage. This introduces some more copying but I think the tradeoff is ok. Newly introduced copies are for favicon response to the embedder and EmbedderNotifications.Testing: Should not change functionality, so covered by existing tests.
Fixes: #39626 and related issues.