Skip to content

Conversation

@arihant2math
Copy link
Contributor

As requested, the mode changes per the preferences. I had to add a shadow to fix the contrast on light mode (the colors/shadowing are roughly similar to the firefox new tab page).

Screenshot 2025-10-29 at 11 38 49 AM

@servo-highfive servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Oct 29, 2025
@servo-highfive servo-highfive added S-needs-code-changes Changes have not yet been made that were requested by a reviewer. and removed S-awaiting-review There is new code that needs to be reviewed. labels Oct 30, 2025
@arihant2math
Copy link
Contributor Author

I should note that I didn't change any styles but color and shadow.

@servo-highfive servo-highfive added S-awaiting-review There is new code that needs to be reviewed. and removed S-needs-code-changes Changes have not yet been made that were requested by a reviewer. labels Nov 2, 2025
Signed-off-by: Ashwin Naren <arihant2math@gmail.com>
@servo-highfive servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Nov 3, 2025
@jdm jdm added this pull request to the merge queue Nov 3, 2025
@servo-highfive servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 3, 2025
Merged via the queue into servo:main with commit c044c7f Nov 3, 2025
32 checks passed
@servo-highfive servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Nov 3, 2025
@arihant2math arihant2math deleted the light-mode-newtab branch November 3, 2025 20:18
@yezhizhen
Copy link
Member

How to swap the theme?

@arihant2math
Copy link
Contributor Author

It's based on the system theme.

@yezhizhen
Copy link
Member

This doesn't seem to work.
#40395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants