-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Implement UIEvent.which #40109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Implement UIEvent.which #40109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
|
🔨 Triggering try run (#18755590934) for Linux (WPT) |
Taym95
commented
Oct 23, 2025
|
Test results for linux-wpt from try job (#18755590934): Flaky unexpected result (17)
Stable unexpected results that are known to be intermittent (25)
Stable unexpected results (1)
|
|
|
Signed-off-by: Taym Haddadi <haddadi.taym@gmail.com>
|
🔨 Triggering try run (#18761903519) for Linux (WPT) |
|
Test results for linux-wpt from try job (#18761903519): Flaky unexpected result (24)
Stable unexpected results that are known to be intermittent (26)
|
|
✨ Try run (#18761903519) succeeded. |
jdm
approved these changes
Oct 23, 2025
mrego
added a commit
to mrego/servo
that referenced
this pull request
Nov 21, 2025
`UIEvent.which` was implemented in servo#40109 and is enabled by default, we don't need it to be listed in the experimental features. Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2025
`UIEvent.which` was implemented in #40109 and is enabled by default, we don't need it to be listed in the experimental features. Testing: No change of behavior. Signed-off-by: Manuel Rego Casasnovas <rego@igalia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement UIEvent.which
Testing: existing test should pass.
Fixes: #40106
Fixes: #40099