script: when fetching a worker script abort if response status is not ok #39468

Gae24 · 2025-09-24T08:50:44Z

According to spec we should abort if the response status is not ok.

Testing: Check tests listed inside issue are not intermittent anymore
Fixes: #39413
Fixes: #22991

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>

Gae24 · 2025-09-24T09:11:47Z

Question, can it happens that the resulting bytes are zero? In which case we should do the same.

There are three other usages of load_whole_resource:
Workerglobalscope::ImportScripts, Serviceworkerglobalscope::run_serviceworker_scope and Worklet::fetch_and_invoke_a_worklet_script.

After a quick check of the spec, we should do the same inside ImportScripts, which uses this algorithm.
Haven't found anything for the other two cases.

github-actions · 2025-09-24T13:40:34Z

🔨 Triggering try run (#17978573011) for Linux (WPT)

github-actions · 2025-09-24T14:06:44Z

Test results for linux-wpt from try job (#17978573011):

Flaky unexpected result (21)

TIMEOUT /FileAPI/url/url-in-tags-revoke.window.html (#19978)
- TIMEOUT [expected PASS] subtest: Fetching a blob URL immediately before revoking it works in <script> tags.
```
Test timed out
```
OK /IndexedDB/idbfactory_open.any.html
- FAIL [expected PASS] subtest: Calling open() with version argument 1.5 should not throw.
```
assert_equals: version expected 1 but got 9007199254740991
```
FAIL [expected PASS] /css/CSS2/text/word-spacing-091.xht
FAIL [expected PASS] /css/WOFF2/metadatadisplay-schema-trademark-008.xht
PASS [expected FAIL] /css/css-flexbox/flex-item-content-is-min-width-max-content.html (#39383)
OK /css/css-fonts/generic-family-keywords-003.html (#38994)
- FAIL [expected PASS] subtest: @font-face matching for quoted and unquoted serif (drawing text in a canvas)
```
assert_equals: quoted serif matches  @font-face rule expected 125 but got 40
```
OK /css/css-text/i18n/ja/css-text-line-break-ja-po-normal.html
- FAIL [expected PASS] subtest: 2030 PER MILLE SIGN may NOT appear at line start if ja and normal
```
assert_approx_equals: expected 100 +/- 1 but got 109
```
OK /fetch/metadata/generated/css-font-face.sub.tentative.html (#34624)
- PASS [expected FAIL] subtest: sec-fetch-storage-access - Not sent to non-trustworthy same-site destination
TIMEOUT /fetch/metadata/generated/css-images.sub.tentative.html (#29047)
- TIMEOUT [expected PASS] subtest: background-image sec-fetch-site - Not sent to non-trustworthy cross-site destination
```
Test timed out
```
OK /html/browsers/browsing-the-web/navigating-across-documents/008.html (#24456)
- PASS [expected FAIL] subtest: Link with onclick form submit to javascript url and href navigation
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/load-pageshow-events-iframe-contentWindow.html (#28681)
- FAIL [expected PASS] subtest: load & pageshow events do not fire on contentWindow of <iframe> element created with src='about:blank'
```
assert_unreached: load should not be fired Reached unreachable code
```
OK /html/browsers/browsing-the-web/navigating-across-documents/navigation-unload-same-origin.window.html (#29049)
- FAIL [expected PASS] subtest: Same-origin navigation started from unload handler must be ignored
```
assert_equals: expected "?pass" but got "?fail"
```
OK /html/browsers/history/the-history-interface/traverse_the_history_2.html (#21383)
- PASS [expected FAIL] subtest: Multiple history traversals, last would be aborted
TIMEOUT [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3.html (#24057)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-2.html (#22154)
- FAIL [expected NOTRUN] subtest: Check that popups from a sandboxed iframe do not escape the sandbox
```
assert_equals: It came from a sandboxed iframe expected "null" but got "http://web-platform.test:8000"
```

OK /html/webappapis/user-prompts/print-during-unload.html (#35944)

FAIL [expected PASS] subtest: print() during unload

assert_array_equals: expected property 1 to be "destination" but got "error: window.print is not a function" (expected array ["start", "destination"] got ["start", "error: window.print is not a function"])

OK /preload/preload-error.sub.html (#37177)

FAIL [expected PASS] subtest: 404 (fetch): main

assert_greater_than: http://web-platform.test:8000/preload/resources/dummy.xml?pipe=status%28404%29&amp;label=fetch should be loaded expected a number greater than 0 but got 0

OK /trusted-types/trusted-types-navigation.html?21-25 (#38997)
- PASS [expected FAIL] subtest: Navigate a window via form-submission with javascript:-urls in enforcing mode.
OK /trusted-types/trusted-types-navigation.html?26-30 (#38807)
- FAIL [expected PASS] subtest: Navigate a window via form-submission with javascript:-urls in report-only mode.
```
promise_test: Unhandled rejection with value: "Unexpected message received: \"No securitypolicyviolation reported!\""
```
- PASS [expected FAIL] subtest: Navigate a frame via form-submission with javascript:-urls in enforcing mode.
TIMEOUT [expected OK] /webstorage/localstorage-about-blank-3P-iframe-opens-3P-window.partitioned.html (#29053)
- TIMEOUT [expected PASS] subtest: StorageKey: test 3P about:blank window opened from a 3P iframe
```
Test timed out
```
OK /xhr/send-redirect.htm (#32026)
- FAIL [expected PASS] subtest: XMLHttpRequest: send() - Redirects (basics) (301, HEAD, redirect.py%3Flocation%3Dcontent.py)
```
assert_equals: expected (string) "HEAD" but got (object) null
```

Stable unexpected results that are known to be intermittent (25)

OK /IndexedDB/idbcursor-continuePrimaryKey-exceptions.any.worker.html (#39277)

FAIL [expected PASS] subtest: IDBCursor continuePrimaryKey() on object store cursor

assert_throws_dom: continuePrimaryKey() should throw if source is not an index function "function() {
        cursor.continuePrimaryKey(2, 2);
      }" threw object "TypeError: cursor.continuePrimaryKey is not a function" that is not a DOMException InvalidAccessError: property "code" is equal to undefined, expected 15

OK /IndexedDB/idbobjectstore_getAll.any.html (#39276)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()
OK /IndexedDB/idbobjectstore_getAll.any.worker.html (#39400)
- PASS [expected FAIL] subtest: Get all values with transaction.commit()

OK /IndexedDB/key-conversion-exceptions.any.html (#39305)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

OK /IndexedDB/key-conversion-exceptions.any.worker.html (#39284)

FAIL [expected PASS] subtest: IDBCursor continue() method with throwing/invalid keys

assert_throws_exactly: key conversion with throwing getter should rethrow function "() =&gt; {
      receiver[method](key);
    }" threw object "TypeError: receiver[method] is not a function" but we expected it to throw object "getter: throwing from getter"

FAIL [expected PASS] /_mozilla/css/stacked_layers.html (#15988)
FAIL [expected PASS] /_mozilla/gfx-rs-gecko/descriptor-ranges.html (#23258)
FAIL [expected PASS] /_mozilla/mozilla/sslfail.html (#10760)
TIMEOUT [expected OK] /_mozilla/mozilla/window_resize_event.html (#36741)
- TIMEOUT [expected PASS] subtest: Popup onresize event fires after resizeTo
```
Test timed out
```
OK /css/css-fonts/generic-family-keywords-001.html (#37467)
- PASS [expected FAIL] subtest: @font-face matching for quoted and unquoted generic(fangsong)
TIMEOUT [expected FAIL] /dom/xslt/large-cdata.html (#38029)
TIMEOUT [expected OK] /fetch/fetch-later/quota/same-origin-iframe/max-payload.https.window.html (#35210)
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-nosrc.html (#34819)
- FAIL [expected PASS] subtest: link click
```
assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/initial-empty-document/iframe-src-aboutblank-navigate-immediately.html (#29048)
- FAIL [expected PASS] subtest: Navigating to a different document with location.assign
```
assert_equals: expected "http://web-platform.test:8000/common/blank.html?1" but got "about:blank"
```
OK /html/browsers/browsing-the-web/navigating-across-documents/replace-before-load/a-click.html (#28697)
- PASS [expected FAIL] subtest: aElement.click() before the load event must NOT replace

OK /html/browsers/windows/embedded-opener-remove-frame.html (#23867)

FAIL [expected PASS] subtest: opener of discarded auxiliary browsing context

assert_object_equals: property "get" expected function "function opener() {
    [native code]
}" got function "function opener() {
    [native code]
}"

OK [expected TIMEOUT] /html/interaction/focus/the-autofocus-attribute/supported-elements.html (#24145)

FAIL [expected NOTRUN] subtest: Host element with delegatesFocus including no focusable descendants should be skipped

assert_equals: expected Element node &lt;input autofocus=""&gt;&lt;/input&gt; but got Element node &lt;body&gt;&lt;div autofocus=""&gt;&lt;/div&gt;&lt;input autofocus=""&gt;&lt;/body&gt;

FAIL [expected NOTRUN] subtest: Area element should support autofocus

promise_test: Unhandled rejection with value: object "TypeError: can't access property "appendChild", w.document.querySelector(...) is null"

OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html (#22647)
CRASH [expected OK] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-1.html (#24066)
OK [expected CRASH] /html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-3.html (#24066)
OK /preload/prefetch-document.html (#37210)
- FAIL [expected PASS] subtest: different-site document prefetch with 'as=document' should not be consumed
```
assert_equals: expected 2 but got 1
```
OK /trusted-types/trusted-types-navigation.html?01-05 (#38975)
- PASS [expected FAIL] subtest: Navigate a window via anchor with javascript:-urls in report-only mode.
OK /webdriver/tests/classic/dismiss_alert/dismiss.py (#39098)
- FAIL [expected PASS] subtest: test_dismiss_in_popup_window
```
AssertionError: no such alert (404): No user prompt is currently active.
```
TIMEOUT [expected OK] /webdriver/tests/classic/perform_actions/navigation.py (#38822)
OK /webdriver/tests/classic/take_element_screenshot/scroll_into_view.py (#39306)
- PASS [expected FAIL] subtest: test_scroll_into_view

Stable unexpected results (1)

OK [expected ERROR] /resource-timing/initiator-type/workers.html

github-actions · 2025-09-24T14:06:55Z

⚠️ Try run (#17978573011) failed.

Gae24 · 2025-09-24T14:22:18Z

Test results for linux-wpt from try job (#17978573011):
Flaky unexpected result (21)

Stable unexpected results that are known to be intermittent (25)

Stable unexpected results (1)
* OK [expected ERROR] `/resource-timing/initiator-type/workers.html`

I've run this test locally with a debug build a couple times and failed everytime.

mrobinson · 2025-09-24T15:27:45Z

I've run this test locally with a debug build a couple times and failed everytime.

Does it fail with an ERROR like in the output above? Have you tried running with a release build?

Gae24 · 2025-09-24T22:19:36Z

I've run this test locally with a debug build a couple times and failed everytime.

Does it fail with an ERROR like in the output above? Have you tried running with a release build?

Oh, I interpreted the result wrong.
The test still fails, prior to this pr it was bumping into the same error of #22991

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>

jdm

Thanks!

Gae24 · 2025-09-29T10:04:44Z

I just noticed that this was added to the merge queue, but I actually have another commit with the additional checks of step 3.
Do I push it, or do you prefer a new pr @jdm?

jdm · 2025-09-29T10:12:30Z

Let's do that in a new PR!

… ok (servo#39468) According to [spec](https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script) we should abort if the response status is not ok. Testing: Check tests listed inside issue are not intermittent anymore Fixes: servo#39413 Fixes: servo#22991 --------- Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>

fetch worker script: abort if response status is not ok

1f5cac1

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>

Gae24 requested a review from gterzian as a code owner September 24, 2025 08:50

servo-highfive added the S-awaiting-review There is new code that needs to be reviewed. label Sep 24, 2025

simonwuelker added the T-linux-wpt Do a try run of the WPT label Sep 24, 2025

github-actions bot removed the T-linux-wpt Do a try run of the WPT label Sep 24, 2025

update test expectation

f561932

Signed-off-by: Gae24 <96017547+Gae24@users.noreply.github.com>

jdm approved these changes Sep 29, 2025

View reviewed changes

servo-highfive removed the S-awaiting-review There is new code that needs to be reviewed. label Sep 29, 2025

jdm added this pull request to the merge queue Sep 29, 2025

servo-highfive added the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 29, 2025

Merged via the queue into servo:main with commit 7a7129e Sep 29, 2025
26 checks passed

servo-highfive removed the S-awaiting-merge The PR is in the process of compiling and running tests on the automated CI. label Sep 29, 2025

Gae24 mentioned this pull request Sep 29, 2025

Use DOMManipulationTaskSource in Workers #10460

Closed

Gae24 deleted the check-response-status branch September 29, 2025 17:09

Gae24 mentioned this pull request Oct 19, 2025

WorkerGlobalScope's importScripts should check response #39993

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

script: when fetching a worker script abort if response status is not ok #39468

script: when fetching a worker script abort if response status is not ok #39468

Uh oh!

Gae24 commented Sep 24, 2025 •

edited by jdm

Loading

Uh oh!

Gae24 commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Gae24 commented Sep 24, 2025

Uh oh!

mrobinson commented Sep 24, 2025

Uh oh!

Gae24 commented Sep 24, 2025

Uh oh!

jdm left a comment

Uh oh!

Gae24 commented Sep 29, 2025

Uh oh!

jdm commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

script: when fetching a worker script abort if response status is not ok #39468

script: when fetching a worker script abort if response status is not ok #39468

Uh oh!

Conversation

Gae24 commented Sep 24, 2025 • edited by jdm Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gae24 commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025

Uh oh!

Gae24 commented Sep 24, 2025

Uh oh!

mrobinson commented Sep 24, 2025

Uh oh!

Gae24 commented Sep 24, 2025

Uh oh!

jdm left a comment

Choose a reason for hiding this comment

Uh oh!

Gae24 commented Sep 29, 2025

Uh oh!

jdm commented Sep 29, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Gae24 commented Sep 24, 2025 •

edited by jdm

Loading