Skip to content

Conversation

@delan
Copy link
Member

@delan delan commented Aug 8, 2025

to use the SpiderMonkey Debugger API as the single source of truth about scripts and their sources for devtools purposes (#38334), we need to keep track of whether scripts come from an actual file or from things like setTimeout(), because for some introductionType values, we want to disregard the script unless it has a //# sourceURL= override (displayURL).

this patch builds on #38363, setting the correct introductionType value in several more cases.

Testing: will undergo many automated tests in #38334
Fixes: part of #36027

delan added a commit that referenced this pull request Aug 8, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan marked this pull request as ready for review August 8, 2025 14:07
@delan delan requested a review from gterzian as a code owner August 8, 2025 14:07
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan force-pushed the more-introductionType-values branch from c5fcd60 to f703486 Compare August 8, 2025 14:41
delan added a commit that referenced this pull request Aug 8, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
@delan delan enabled auto-merge August 9, 2025 04:54
@delan delan added this pull request to the merge queue Aug 9, 2025
delan added a commit that referenced this pull request Aug 9, 2025
Co-authored-by: atbrakhi <atbrakhi@igalia.com>
Signed-off-by: Delan Azabani <dazabani@igalia.com>
Merged via the queue into main with commit 6471587 Aug 9, 2025
21 checks passed
@delan delan deleted the more-introductionType-values branch August 9, 2025 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants